Fix code stability issue #1173 + Fix build 'remarks' PR #1201 #1210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
This PR fixes issue #1173 reported by NCO during HAFS.v1 implementation regarding ww3_outp debug build failure as well as the addition of PR #1201 to address the fix for build remarks
Description
With these changes the debug build will not encounter a failure while running ww3_outp in addition to the elimination of some build remarks for WW3.
Please also include the following information:
Issue(s) addressed
fixes noaa-emc/ww3/issues/< code stability test failed in ww3_outp #1173>
Commit Message
Please provide a short summary of this PR, which will be used during Squash and Merge and will be shown as a git log message. Be sure to add any co-authors here.
Check list
Testing
Four tests were conducted, with and without the fixes, and with Release and Debug build flags. The runs with and without the fixes are reproducible with the Release flag, which is expected. The run with the fix and debug flag fixes the issue with code instability while running ww3_outp. Runs without the fix and with the Debug flag reproduce the error that NCO had reported.
ww3_ufs1.1 was tested. ww3_outp was executed to reproduce the error and check if the bug fix has been effective.
parts of Matrix 12 , on Hera with intel compiler