Add fields and fixes to dev/ufs-weather-model branch, as required by Coastal App #1291
Conversation
* hs and 2dstr in export fields match history files * add placeholders for additional fields
* allow for masking of export variables via fillvalue
* ensures consistency with calculation of lamult and lasl export fields
* add routine to calculate the ubrx,ubry * revert change to 'tag' for sxx,syy,sxy fields. the tag to get the stresses as output is sxy, which in w3iogonc then turns on the output of sxx,sxy,syy. this is like the tag 'cur' which is used to turn on the output for both cx and cy
|
@JessicaMeixner-NOAA @MatthewMasarik-NOAA There are a couple of bug fixes in this PR relative to the mesh cap used for WW3 relevant for gfsv17/gefsv13 in addition to the ufs-coastal app. Would you please take a look and re-evaluate whether it will be held until November? Thanks. |
|
@DeniseWorthen, I will bring this up with the team. |
Hi @DeniseWorthen, we discussed this at our waves group meeting Monday. Avichal advised that we should stick to the temporary policy until we have more help given how short staffed we are. If they are needed for gfsv17 or gefsv13 implementation then it could be processed now, but if not then it should wait. |
|
@uturuncoglu Please discuss your path forward w/ the UFS Coastal App team in light of the above decision. |
|
@DeniseWorthen Okay. Thanks. It seems that we need to have PR in costal fork rather than UFS WM level. We could also merge these changes to our WW3 fork. Anyway, Let me talk with them on our regular Monday meeting and update you. Does it sounds good? BTW, thanks for all your help. @janahaddad if you don't mind could you add this discussion to our items for Monday. |
|
Thanks @DeniseWorthen and @uturuncoglu -- setting up a time for UFS Coastal to discuss Tues 9/3. |
|
Hi @DeniseWorthen @uturuncoglu, the pause on PRs is complete, so we will start reviewing this PR now. Thank you for your patience. |
|
@MatthewMasarik-NOAA Thanks for the update. @DeniseWorthen I wonder if this is synced with develop? |
|
@uturuncoglu This PR will be going to dev/ufs-weather-model branch, which is about a year behind develop. This particular PR branch might be one-behind dev/ufs-weather-model but it will need to be updated again after the pio PR goes in. |
|
@DeniseWorthen Yes. Sorry. It is my fault. Since most of the components are using develop, I assumed that this will also go to develop. |
Pull Request Summary
Updates mesh cap as required by UFS-Coastal App development. Adds export of additional coupling fields. Makes several small fixes to the the netcdf output capability in the mesh cap. Initializes value of TRHO(2).
Description
Issue(s) addressed
Commit Message
Update mesh cap for additional coupling fields. Make bug fixes to the netcdf output interface in the mesh cap.
Check list
Testing
This has been tested in UWM for all RTs utilizing WW3. As noted in the current UFS PR (ufs-community/ufs-weather-model#2367), the fix to
TRHO(2)will change baselines for two UWM RTs, due to B4B differences in the WW3 restart file. All other fields are B4B.Note also that a new UWM PR with additional RT script level changes will be opened and linked with this WW3 PR. Testing has shown that using this feature branch impacts only the same two UWM RTs.