Adding New Vegetative Canopy Data for AQM Coupling #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… feature/aqm_canopy
This was referenced Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we add five new vegetative canopy datasets based on satellite observations, which is currently passed from the AQM chemical component to the ufs-weather-model for incorporation in the optional sub-canopy parameterizations in ccpp-physics PBL schemes (SATMEDMF). These include the forest canopy height (FCH), forest fraction (FRT), clumping index (CLU), population density (POPU), and leaf area index from (LAI). These datasets have recently been published in a NOAA-ARL Tech Memo and at NCEI. This also adds three additional AQM coupled photolysis diagnostics used in helping best evaluate and understand associated canopy effects in AQM.
Issue(s) addressed
#927
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
RDHPCs Hera.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Yes. These add new variables only used in ccpp-physics with option turned on. The do_canopy option is turned off by default. 'logical :: do_canopy = .false. !< flag for canopy option'
Have the ufs-weather-model regression test been run? On what platform?
No.
No. - Please commit the regression test log files in your ufs-weather-model branch
Dependencies
If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)
https://github.com/noaa-oar-arl/ccpp-physics/tree/feature/aqm_canopy2
Do PRs in upstream repositories need to be merged first?
@iri01