Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ESMF Redist instead of Remap for history bundles with 'cubed_sphere_grid' output grid #929

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

DusanJovic-NOAA
Copy link
Collaborator

Description

Fix a bug in the write grid component where regional cubed sphere output have undefined (zero) values on some points on the edge (outermost rows and columns). This happens only when model is compiled with -D32BIT=ON option due to round off differences in lat/lon grid coordinate values between forecast and write grid component. When model is compiled without -D32BIT=ON, both forecast and write grid components use 64bit values for grid coordinates and in that case during the remapping all grid points are defined (i.e. 'inside the model domain'). Solution is to use ESMF Redist instead of Remap for all cubed sphere grid outputs.

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

Testing

How were these changes tested? Yes. UFS regression test, and Arctic domain test as reported in ufs-community/ufs-weather-model#2589
What compilers / HPCs was it tested with? Intel and GNU on Hercules.
Are the changes covered by regression tests? Yes.
Have the ufs-weather-model regression test been run? Yes. On what platform? Hercules

  • Will the code updates change regression test baseline? Yes. All regression test that output cubed sphere history files.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zeros along edges of regression test output
1 participant