-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gfs_wavepostpnt
dependencies to gfs_cleanup
#3313
Add gfs_wavepostpnt
dependencies to gfs_cleanup
#3313
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks logical
Since this is a hotfix, I am inclined to merge asap and let it be included in the next CI run. |
I was looking at the logic for this and I noticed that arch has sections for many different post jobs (not just waves). It looks to me like cleanup was supposed to wait for arch, but maybe wasn't? I'm pointing this out because maybe it's not just wave post that needs to be added here. |
@JessicaMeixner-NOAA The arch dependencies are already in the |
Thanks @AntonMFernando-NOAA - In the branch I looked at, which seems to have been out of date, the lines you added here already appeared in the arch dependencies. So - ignore my comment. |
Description
The
gfs_cleanup
does not have thegfs_wavepostpnt
dependency, which leads to failures in GFS cases. This PR addresses this issue.Resolves #3310
Refs #3238
Type of change
Change characteristics
How has this been tested?
Checklist