Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gfs_wavepostpnt dependencies to gfs_cleanup #3313

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

AntonMFernando-NOAA
Copy link
Contributor

@AntonMFernando-NOAA AntonMFernando-NOAA commented Feb 10, 2025

Description

The gfs_cleanup does not have the gfs_wavepostpnt dependency, which leads to failures in GFS cases. This PR addresses this issue.

Resolves #3310
Refs #3238

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

  • CI test on HERA

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks logical

@AntonMFernando-NOAA AntonMFernando-NOAA self-assigned this Feb 10, 2025
@aerorahul
Copy link
Contributor

Since this is a hotfix, I am inclined to merge asap and let it be included in the next CI run.

@JessicaMeixner-NOAA
Copy link
Contributor

I was looking at the logic for this and I noticed that arch has sections for many different post jobs (not just waves). It looks to me like cleanup was supposed to wait for arch, but maybe wasn't?

I'm pointing this out because maybe it's not just wave post that needs to be added here.

@AntonMFernando-NOAA
Copy link
Contributor Author

I was looking at the logic for this and I noticed that arch has sections for many different post jobs (not just waves). It looks to me like cleanup was supposed to wait for arch, but maybe wasn't?

I'm pointing this out because maybe it's not just wave post that needs to be added here.

@JessicaMeixner-NOAA The arch dependencies are already in the cleanup.
I think modifying the arch dependencies and then adding the arch dependency to cleanup job is the right way to go. If you think otherwise let me know.

@JessicaMeixner-NOAA
Copy link
Contributor

I was looking at the logic for this and I noticed that arch has sections for many different post jobs (not just waves). It looks to me like cleanup was supposed to wait for arch, but maybe wasn't?
I'm pointing this out because maybe it's not just wave post that needs to be added here.

@JessicaMeixner-NOAA The arch dependencies are already in the cleanup. I think modifying the arch dependencies and then adding the arch dependency to cleanup job is the right way to go. If you think otherwise let me know.

Thanks @AntonMFernando-NOAA - In the branch I looked at, which seems to have been out of date, the lines you added here already appeared in the arch dependencies. So - ignore my comment.

@aerorahul aerorahul merged commit ccb4679 into NOAA-EMC:develop Feb 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete job dependencies for gfs_cleanup
5 participants