generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute aggregation/transformation + plotting & evaluation analyses #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection() into standard processing
…ribute transforms
…rmation functions
…t transformation script's documentation
…at strings just-in-case user doesn't use f'{dir_base}'
…ssing comids or variables have been identified, else write message that there could be an issue in the logic
…yle theme (#33) * Create custom matplotlib stylesheet for RaFTS plots * Flip axes on scatter; change perf to pred for clarity * Change perf to pred for clarity * Read in mplstyle file directly from fs_algo * incorporate plotting functions into fs_perf_viz.py * Use functions for creating file output paths * Change perf_map to pred_map --------- Co-authored-by: glitt13 <[email protected]>
21 tasks
…fficient s3 retrievals of basin attribute data with proc_attr_mlti_wrap. Still needs integration into full processing.
…ibutes all at once; doc: update documentation pertaining to refactoring
… change in script to a different config file path
…her than single-comid acquisition
…he attribute grabbing needed when creating new transformation attributes
…demo in the attribute grabbing script
…xceed 10% of data
…nd response dataset; refactor: train/test split logic now considers common indices for simplicity
…e same comid; ensure unique comids b/w train/test split, ensure NA and duplicates consistently handled across multiple steps with the creation of combine_resp_gdf_comid_wrap()
ssorou1
previously approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- fs_proc
python proc_eval_metrics.py ~\git\formulation-selector\scripts\eval_ingest\xssa\xssa_config.yaml
It was successfully done. - proc.attr.hydfab
Rscript fs_attrs_grab.R ~/git/formulation-selector/scripts/eval_ingest/xssa/xssa_attr_config.yaml
The attribute folder could not be populated in Windows environment. Please refer to issue R package not being able to read .parquet files in Windows #35.
Upon manually copying the parquet files, this step was done successfully.
The unit tests were implemented in R and Python. In R, 46 unit tests were passed and 4 failed. In Python, 33 passed and one failed. - fs_algo training:
python fs_proc_algo.py ~\git\formulation-selector\scripts\eval_ingest\xssa\xssa_algo_config.yaml
This step is successfully implemented.
ssorou1
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An approach to aggregate and transform existing attribute data to create new attribute data
Additionally, create & save plots that visualize results and aid in algorithm performance
Additions
pca_stdscaled_tfrm
,plot_pca_stdscaled_tfrm
,plot_pca_stdscaled_cumulative_var
,std_pca_plot_path
, functions comprehensively summarized in theplot_pca_save_wrap
wrappersave_feat_imp_fig_wrap
wrapperAlgoEvalPlotLC
class, with functions comprehensively summarized with theplot_learning_curve_save_wrap
wrapperplot_pred_vs_obs_wrap
wrapperplot_map_pred_wrap
wrapperplot_best_algo_wrap
wrapper/scripts/analysis/fs_proc_viz_best_ealstm.py
and the more-formal/scripts/eval_ingest/ealstm/proc_ealstm_agu24.py
plus associated config files in theealstm/
directoryfs_proc_algo_viz.py
as an updated version offs_proc_algo.py
with new evaluation and plotting featuresRemovals
Changes
Testing
test_tfrm_attr.py
has been challenging to implement under a normal unittest package approach owing to a mysteriousdask.dataframe as dd
error. Implemented a work-around that partially tests this package by nixing most instances of using classes.Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other