address failing test on windows #93
Merged
+4
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is this for/how does it work? Is it ready for review or should it be marked draft? |
|
@rbolgaryn this is still failing |
|
Have not been able to figure out why it is failing on Windows. I just commented out the lines that were causing the problem in the "legacy" implementation. Since it is not used other than for testing, it should be OK. This PR should be ready to merge. |
GabrielKS
reviewed
Feb 6, 2025
jd-lara
reviewed
Feb 7, 2025
remove unused code
GabrielKS
approved these changes
Feb 7, 2025
jd-lara
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing test for windows