add Yft, Ytf to power_network_matrix Ybus #95
+144
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add branch admittance matrices (Yft, Ytf) to the Ybus structure so that we can efficiently calculate branch flows in PowerFlows in AC power flow calculation. |
|
Performance Results
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 77.61% 77.83% +0.22%
==========================================
Files 14 14
Lines 1398 1430 +32
==========================================
+ Hits 1085 1113 +28
- Misses 313 317 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
formatting Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
GabrielKS
suggested changes
Jan 15, 2025
jd-lara
requested changes
Jan 16, 2025
|
This PR should be good now |
jd-lara
reviewed
Jan 30, 2025
jd-lara
requested changes
Jan 30, 2025
|
todo: 1) make also the ft, tb, sb, nullable (don"t populate those either), 2) update docstrings for Ybus struct |
GabrielKS
reviewed
Feb 3, 2025
| @@ -2,55 +2,85 @@ | |||
| Nodal admittance matrix (Ybus) is an N x N matrix describing a power system with N buses. It represents the nodal admittance of the buses in a power system. | |||
|
|
|||
| The Ybus Struct is indexed using the Bus Numbers, no need for them to be sequential | |||
|
|
|||
| The fields yft and ytf are the branch admittance matrices for the from-to and to-from branch admittances respectively. They are indexed with the branch numbers and the bus numbers. | |||
| The branch numbers are sequential. The bus numbers are represented by fb, tb arraus of sequential bus indices (internal bus indices). | |||
There was a problem hiding this comment.
Suggested change
| The branch numbers are sequential. The bus numbers are represented by fb, tb arraus of sequential bus indices (internal bus indices). | |
| The branch numbers are sequential. The bus numbers are represented by fb, tb arrays of sequential bus indices (internal bus indices). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for opening a PR to PowerNetworkMatrices.jl, please take note of the following when making a PR:
Check the contributor guidelines