Merge pull request #33 from NREL-Sienna/jm/aqua

Add and fix aqua tests
NREL-Sienna · Nov 22, 2024 · 22bc892 · 22bc892
2 parents ab58437 + 957a261
commit 22bc892
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 3 deletions.
diff --git a/Project.toml b/Project.toml
@@ -41,3 +41,5 @@ Reexport = "1"
 StatsBase = "0.34"
 TimeZones = "1"
 julia = "^1.8"
+TimeSeries = "0.24"
+JSON = "^0.21"
diff --git a/src/util/sienna/helper_functions.jl b/src/util/sienna/helper_functions.jl
@@ -151,9 +151,9 @@ function get_forecast_values(ts::Nothing)
 end
 
 function get_outage_time_series_data(
-    gen::Union{SI, BR},
+    gen::Union{PSY.StaticInjection, PSY.Branch},
     s2p_meta::S2P_metadata,
-) where {SI <: PSY.StaticInjection, BR <: PSY.Branch}
+)
     # Get GeometricForcedOutage SupplementalAttribute of the generator g
     outage_sup_attrs =
         PSY.get_supplemental_attributes(PSY.GeometricDistributionForcedOutage, gen)

diff --git a/test/Project.toml b/test/Project.toml
@@ -1,9 +1,10 @@
 [deps]
+Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 CSV = "336ed68f-0bac-5ca0-87d4-7b16caf5d00b"
 DataFrames = "a93c6f00-e57d-5684-b7b6-d8193f3e46c0"
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
-PowerSystemCaseBuilder = "f00506e0-b84f-492a-93c2-c0a9afc4364e"
 PRASInterface = "4b496c86-8d00-441d-b504-079c710e0aa7"
+PowerSystemCaseBuilder = "f00506e0-b84f-492a-93c2-c0a9afc4364e"
 PowerSystems = "bcd98974-b02a-5e2f-9ee0-a103f5c450dd"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 TimeSeries = "9e3dc215-6440-5c97-bce1-76c03772f85e"

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -1,6 +1,7 @@
 using PRASInterface
 using Test
 
+import Aqua
 import PowerSystems
 import PowerSystemCaseBuilder
 import CSV
@@ -15,6 +16,14 @@ const PSCB = PowerSystemCaseBuilder
 
 include("rts_gmlc.jl")
 
+@testset "Aqua.jl" begin
+    Aqua.test_unbound_args(PRASInterface)
+    Aqua.test_undefined_exports(PRASInterface)
+    Aqua.test_ambiguities(PRASInterface)
+    Aqua.test_stale_deps(PRASInterface)
+    Aqua.test_deps_compat(PRASInterface)
+end
+
 #=
 Don't add your tests to runtests.jl. Instead, create files named