Reconcile total site load #456
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adfarth just tracking a couple other notes here:
No fixes for these yet but I'll track and see if I can follow up with good fixes. One concern is the electrical load could be a weird |
zolanaj
changed the title
|
@adfarth Ready for you to check! The steam turbine is left out of all of this for now but the other heating and cooling loads have been caught up. I added a result in |
|
@zolanaj would you mind adding a CHANGELOG entry for this? And perhaps updating the PR description with the same entry? |
adfarth
reviewed
Feb 6, 2025
| # tech electric loads from thermal techs | ||
| + sum(m[:dvCoolingProduction][t, ts] / p.cooling_cop[t][ts] for t in setdiff(p.techs.cooling,p.techs.ghp), ts in p.time_steps) | ||
| + sum(m[:dvHeatingProduction][t, q, ts] / p.heating_cop[t][ts] for q in p.heating_loads, t in p.techs.electric_heater, ts in p.time_steps) | ||
| + sum(p.ghp_electric_consumption_kw[g,ts] * m[:binGHP][g] for g in p.ghp_options, ts in p.time_steps) |
There was a problem hiding this comment.
@zolanaj two questions on this:
- Did you intentionally choose
p.time_stepsinstead ofp.time_steps_with_grid? Honestly, so few people are using the single outage modeling that it probably doesn't matter much anymore, but just wanting to know if we should include a note about this choice - in the load balance constraints, we include
- p.s.cooling_load.loads_kw_thermal[ts] / p.cooling_cop["ExistingChiller"][ts]
You described this as "That subtraction of cooling load is due to our electric load being inclusive of the cooling load which is met by the electric chiller. The cooling production three lines up from what's highlighted allows for either the electric chiller meeting the load (i.e., no change in electricity consumption) or a full or partial replacement by ASHP, or an absorption chiller."
Should that be included here too?
adfarth
reviewed
Feb 6, 2025
| - sum(m[:dvProductionToWaste][t,q,ts] for t in p.techs.chp, q in p.heating_loads, ts in p.time_steps) #minus CHP waste heat | ||
| + sum(m[:dvSupplementaryThermalProduction][t,ts] for t in p.techs.chp, ts in p.time_steps) # plus CHP supplemental firing thermal generation | ||
| - sum(m[:dvProductionToStorage][b,t,ts]*(1-p.s.storage.attr[b].charge_efficiency*p.s.storage.attr[b].discharge_efficiency) for t in setdiff(union(p.techs.heating, p.techs.chp), p.techs.ghp), b in p.s.storage.types.thermal, ts in p.time_steps) #minus thermal storage losses | ||
| - sum(m[:dvProductionToStorage][b,t,ts]*(1-p.s.storage.attr[b].charge_efficiency*p.s.storage.attr[b].discharge_efficiency) for t in setdiff(union(p.techs.heating, p.techs.chp), union(p.techs.ghp, p.techs.electric_heater)), b in p.s.storage.types.thermal, ts in p.time_steps) #minus thermal storage losses | ||
| ) | ||
| # - AnnualSteamToSteamTurbine # minus steam going to SteamTurbine; already adjusted by p.hours_per_time_step | ||
| ) |
There was a problem hiding this comment.
@zolanaj could you confirm if the TODO below is now addressed?
adfarth
reviewed
Feb 6, 2025
| ) | ||
| # - AnnualRESteamToSteamTurbine # minus RE steam feeding steam turbine, adjusted by p.hours_per_time_step | ||
| # + AnnualSteamTurbineREThermOut #plus steam turbine RE generation, adjusted for storage losses, adjusted by p.hours_per_time_step (not included in first line because p.tech_renewable_energy_fraction for SteamTurbine is 0) | ||
| ) | ||
|
|
||
| # Total heat (steam/hot water heat that is not being used to generate electricity) | ||
| AnnualHeatkWh = @expression(m,p.hours_per_time_step*( | ||
| sum(m[:dvHeatingProduction][t,q,ts] for t in setdiff(union(p.techs.heating, p.techs.chp), p.techs.ghp), q in p.heating_loads, ts in p.time_steps) #total heat generation (need to see how GHP fits into this) | ||
| sum(m[:dvHeatingProduction][t,q,ts] for t in setdiff(union(p.techs.heating, p.techs.chp), union(p.techs.ghp, p.techs.electric_heater)), q in p.heating_loads, ts in p.time_steps) #total heat generation (need to see how GHP fits into this) |
There was a problem hiding this comment.
Could the GHP comment here be removed, if addressed?
adfarth
reviewed
Feb 6, 2025
| @@ -47,6 +47,7 @@ function add_site_results(m::JuMP.AbstractModel, p::REoptInputs, d::Dict; _n="") | |||
| r["annual_onsite_renewable_electricity_kwh"] = round(value(m[:AnnualOnsiteREEleckWh]), digits=2) | |||
| r["onsite_renewable_electricity_fraction_of_elec_load"] = round(value(m[:AnnualOnsiteREEleckWh])/value(m[:AnnualEleckWh]), digits=4) | |||
| r["onsite_and_grid_renewable_electricity_fraction_of_elec_load"] = round((value(m[:AnnualOnsiteREEleckWh]) + value(m[:AnnualGridREEleckWh])) /value(m[:AnnualEleckWh]), digits=4) | |||
| r["electric_load_converted_from_thermal_kwh"] = round(value(m[:AnnualEleckWh]) - (sum(p.s.electric_load.loads_kw) * p.hours_per_time_step), digits=2) | |||
There was a problem hiding this comment.
for the naming of this, just confirming that there aren't instances in which REopt competes one electric tech against another more efficient tech, which could change the load? (not sure how important that would even be here). Would you mind adding this to the help text at the top with a brief commented description?
adfarth
reviewed
Feb 6, 2025
| ) | ||
| # - AnnualRESteamToSteamTurbine # minus RE steam feeding steam turbine, adjusted by p.hours_per_time_step | ||
| # + AnnualSteamTurbineREThermOut #plus steam turbine RE generation, adjusted for storage losses, adjusted by p.hours_per_time_step (not included in first line because p.tech_renewable_energy_fraction for SteamTurbine is 0) | ||
| ) | ||
|
|
||
| # Total heat (steam/hot water heat that is not being used to generate electricity) | ||
| AnnualHeatkWh = @expression(m,p.hours_per_time_step*( | ||
| sum(m[:dvHeatingProduction][t,q,ts] for t in setdiff(union(p.techs.heating, p.techs.chp), p.techs.ghp), q in p.heating_loads, ts in p.time_steps) #total heat generation (need to see how GHP fits into this) | ||
| sum(m[:dvHeatingProduction][t,q,ts] for t in setdiff(union(p.techs.heating, p.techs.chp), union(p.techs.ghp, p.techs.electric_heater)), q in p.heating_loads, ts in p.time_steps) #total heat generation (need to see how GHP fits into this) | ||
| - sum(m[:dvProductionToWaste][t,q,ts] for t in p.techs.chp, q in p.heating_loads, ts in p.time_steps) #minus CHP waste heat | ||
| + sum(m[:dvSupplementaryThermalProduction][t,ts] for t in p.techs.chp, ts in p.time_steps) # plus CHP supplemental firing thermal generation |
There was a problem hiding this comment.
@zolanaj would you mind looking into whether dvSupplementaryThermalProduction is being double counted here? I.e., is it already included in dvHeatingProduction?
adfarth
reviewed
Feb 6, 2025
| - sum(m[:dvProductionToWaste][t,q,ts]* p.tech_renewable_energy_fraction[t] for t in p.techs.chp, q in p.heating_loads, ts in p.time_steps) #minus CHP waste heat | ||
| + sum(m[:dvSupplementaryThermalProduction][t,ts] * p.tech_renewable_energy_fraction[t] for t in p.techs.chp, ts in p.time_steps) # plus CHP supplemental firing thermal generation | ||
| - sum(m[:dvProductionToStorage][b,t,ts]*p.tech_renewable_energy_fraction[t]*(1-p.s.storage.attr[b].charge_efficiency*p.s.storage.attr[b].discharge_efficiency) for t in setdiff(union(p.techs.heating, p.techs.chp), p.techs.ghp), b in p.s.storage.types.thermal, ts in p.time_steps) #minus thermal storage losses, note does not account for p.DecayRate | ||
| - sum(m[:dvProductionToStorage][b,t,ts]*p.tech_renewable_energy_fraction[t]*(1-p.s.storage.attr[b].charge_efficiency*p.s.storage.attr[b].discharge_efficiency) for t in setdiff(union(p.techs.heating, p.techs.chp), union(p.techs.ghp, p.techs.electric_heater)), b in p.s.storage.types.thermal, ts in p.time_steps) #minus thermal storage losses, note does not account for p.DecayRate | ||
| ) | ||
| # - AnnualRESteamToSteamTurbine # minus RE steam feeding steam turbine, adjusted by p.hours_per_time_step | ||
| # + AnnualSteamTurbineREThermOut #plus steam turbine RE generation, adjusted for storage losses, adjusted by p.hours_per_time_step (not included in first line because p.tech_renewable_energy_fraction for SteamTurbine is 0) | ||
| ) | ||
|
|
||
| # Total heat (steam/hot water heat that is not being used to generate electricity) |
There was a problem hiding this comment.
@zolanaj could you modify the descriptor of this calculation to describe something along the lines of "end use load" so we remember next time we look at this? :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uncomments code that tracks electrical load attributable to thermal technologies when calculating the expression
m[:AnnualEleckWh]TODO note at end of add_re_tot_calcs(): ensure no double counting once AnnualEleckWh accounts for electric heating and cooling loads