Skip to content

Commit

Permalink
Show variable label and value for upgrade script
Browse files Browse the repository at this point in the history
This is being used both when a variable name changes and when a variable's value changes, so showing "Changed 'variable_name' to: [variable value]" is confusing when the variable name changed but the variable value did not change. Showing "variable_name = [variable_value]" is clear in either case.
  • Loading branch information
cpaulgilman committed Dec 4, 2024
1 parent f15138d commit b9fbca4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/project.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -502,11 +502,11 @@ static void fcall_vuc_value( lk::invoke_t &cxt )
VersionUpgrade::log( VersionUpgrade::VAR_ADDED,
"Added '" + label + "', " + vv_strtypes[type] + ": " + valstr, reason ) );
}
else
else // variable's value or its name may have changed
{
vuc->GetLog( vuc->GetName() ).push_back(
VersionUpgrade::log( VersionUpgrade::VAR_CHANGED,
"Changed '" + label + "' to: " + valstr, reason ) );
label + " = " + valstr, reason ) );
}

cxt.result().assign( ok ? 1.0 : 0.0 );
Expand Down

0 comments on commit b9fbca4

Please sign in to comment.