Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marine, Geothermal UI fixes #1591

Merged
merged 22 commits into from
Nov 28, 2023
Merged

Marine, Geothermal UI fixes #1591

merged 22 commits into from
Nov 28, 2023

Conversation

mjprilliman
Copy link
Collaborator

Description

-Mac UI overlap issues addressed
-Fix show/hide issues with marine costs
-Change units of geothermal reservoir_pressure_change variable
-Update wave, tidal resource library columns and example files

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Nov 17, 2023
@mjprilliman mjprilliman self-assigned this Nov 17, 2023
@janinefreeman janinefreeman self-requested a review November 17, 2023 16:46
@janinefreeman
Copy link
Collaborator

@cpaulgilman I can check everything in this PR except the Mac forms.

Copy link
Collaborator

@janinefreeman janinefreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed everything except Mac/Linux spacing, all looks good with latest commit

@cpaulgilman
Copy link
Collaborator

cpaulgilman commented Nov 17, 2023

Reviewed everything except Mac/Linux spacing, all looks good with latest commit

@janinefreeman Can you check this again after I merged in ui-mac-fixes? I'm getting a mimo error for Geothermal on a Mac -- do you see that in Windows?

@mjprilliman
Copy link
Collaborator Author

Reviewed everything except Mac/Linux spacing, all looks good with latest commit

@janinefreeman Can you check this again after I merged in ui-mac-fixes? I'm getting a mimo error for Geothermal on a Mac -- do you see that in Windows?

Just for a sanity check did you have the same branch name checked out in ssc?

@cpaulgilman
Copy link
Collaborator

Reviewed everything except Mac/Linux spacing, all looks good with latest commit

@janinefreeman Can you check this again after I merged in ui-mac-fixes? I'm getting a mimo error for Geothermal on a Mac -- do you see that in Windows?

Just for a sanity check did you have the same branch name checked out in ssc?

Ah, missed that.

@mjprilliman mjprilliman merged commit 25c9af7 into develop Nov 28, 2023
4 checks passed
@mjprilliman mjprilliman deleted the marine-geothermal-fixes branch November 28, 2023 20:31
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants