Fixes #1577 #1610
Merged
Fixes #1577 #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technology comparison working but financial comparison not working between hybrids and non-hybrids
mjprilliman
reviewed
Nov 29, 2023
src/variablegrid.cpp
Outdated
| @@ -151,8 +151,8 @@ void VariableGridData::Init() | |||
| ConfigInfo* ci = m_cases[iCase]->GetConfiguration(); | |||
| for (size_t iVarTable = 0; iVarTable < m_var_info_lookup_vec[iCase].size(); iVarTable++) { | |||
| // iterate over case vartables | |||
| wxString prepend = ""; | |||
| if (ci->Technology.size() > 1) prepend = ci->Technology[iVarTable].Lower() + "_"; | |||
| wxString prepend = ci->Technology[iVarTable].Lower() + "_"; | |||
There was a problem hiding this comment.
Think there's still an issue with some of the prepends having spaces in them, which is causing crashes when opening another case with Inputs Browser open:
There was a problem hiding this comment.
Issue seems consistent when you open another case with inputs browser open for these prepends with spaces. Might need to do a find and replace for " " or use different naming scheme.
mjprilliman
approved these changes
Nov 30, 2023
Fix feedback in spaces in names in #1610
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some comparison limitations
Using test file with hybrid and non-hybrid cases and note that non-hybrid cases have variables prepended with technology name (e.g. pvwatts_tilt)
SAM_1577.zip