Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPH models pull request #1900

Merged
merged 140 commits into from
Nov 21, 2024
Merged

IPH models pull request #1900

merged 140 commits into from
Nov 21, 2024

Conversation

sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Nov 7, 2024

Please test and resolve issues to merge into for release here!
Goes with NREL/ssc#1238

update default costs for mslf iph
move financial model variable definition to callbacks to set on load
@cpaulgilman
Copy link
Collaborator

@taylorbrown75 For IPH configurations with the Single Owner financial model, I think the "Electricty Rates" page name in the navigation menu should be "Electricity Purchases" to be consitent with front-of-meter CSP and other configurations where electricity purchases are an operating expense. This is to distinguish from behind-the-meter configurations where "electricity rates" are used to calculate electricity bill savings. (You can see that there are separate Help topics for "Electricity Rates" and "Electricity Purchases" so we have separate places to explain how those inputs work.)

@taylorbrown75
Copy link
Collaborator

@taylorbrown75 For IPH configurations with the Single Owner financial model, I think the "Electricty Rates" page name in the navigation menu should be "Electricity Purchases" to be consitent with front-of-meter CSP and other configurations where electricity purchases are an operating expense. This is to distinguish from behind-the-meter configurations where "electricity rates" are used to calculate electricity bill savings. (You can see that there are separate Help topics for "Electricity Rates" and "Electricity Purchases" so we have separate places to explain how those inputs work.)

Fixed with (c06063b)

@sjanzou sjanzou merged commit 1d506fb into develop Nov 21, 2024
8 checks passed
@cpaulgilman cpaulgilman added enhancement added to release notes PR and/or issue has been added to release notes for a public release labels Dec 10, 2024
@cpaulgilman cpaulgilman added this to the SAM Fall 2024 Release milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants