Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solar weather file downloads to GOES V4 #1945

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Conversation

cpaulgilman
Copy link
Collaborator

Update default download on Location and Resource page to use NSRDB GOES V4.0.0, which has data from 1998 to 2023.

Note that files downloaded from SAM include the NSRDB API endpoint name like "GOES-tmy-v4-0-0" in the file name.

Testing requires building SAM-private or, for open-source builds, temporarily setting the NREL Developer API key and email in private.h.

Items to test for locations covered by GOES V4 (U.S., Central America, southern part of Canada, and northern part of South America; see NSRDB website for coverage map):

  • Default TMY download should include "GOES-tmy-v4-0-0" endpoint in file name.
  • Diurnal shape of DNI, DHI, and GHI should peak around Noon. (Initial release of GOES V4 peaked around 8 pm.)
  • Download with "Choose year" option should show 1998 through 2023 in list of available years for both 60-minute and 30-minute option. Downloaded files should have "GOES-aggregated-v4-0-0" in name.
  • Advanced option should show data for GOES CONUS V4, GOES Aggregated V4, and GOES TMY V4 endpoints, in addition to older PSM V3 endpoints. (GOES Full Disc V4 should not be included in list.)

Fixes #1920

Note PySAM resource tools need to be updated as well: https://github.com/NREL/pysam/blob/main/files/ResourceTools.py

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.
  • This change requires updating the PySAM files via export_config. Please see When do the PySAM files need to be regenerated?

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@cpaulgilman cpaulgilman added this to the SAM Fall 2024 Release milestone Dec 5, 2024
@cpaulgilman cpaulgilman self-assigned this Dec 5, 2024
Copy link
Collaborator

@mjprilliman mjprilliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all bullet points listed and all worked as expected.

@cpaulgilman cpaulgilman merged commit b0fbb9e into develop Dec 6, 2024
8 checks passed
@cpaulgilman cpaulgilman deleted the nsrdb-v4-api branch December 6, 2024 18:16
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update NSRDB downloads to V4
2 participants