Update solar weather file downloads to GOES V4 #1945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update default download on Location and Resource page to use NSRDB GOES V4.0.0, which has data from 1998 to 2023.
Note that files downloaded from SAM include the NSRDB API endpoint name like "GOES-tmy-v4-0-0" in the file name.
Testing requires building SAM-private or, for open-source builds, temporarily setting the NREL Developer API key and email in private.h.
Items to test for locations covered by GOES V4 (U.S., Central America, southern part of Canada, and northern part of South America; see NSRDB website for coverage map):
Fixes #1920
Note PySAM resource tools need to be updated as well: https://github.com/NREL/pysam/blob/main/files/ResourceTools.py
Type of change
Please delete options that are not relevant.
Checklist:
If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.