Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solar interpolation macro #1956

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Solar interpolation macro #1956

merged 2 commits into from
Dec 6, 2024

Conversation

dguittet
Copy link
Collaborator

@dguittet dguittet commented Dec 6, 2024

Description

Fixes #1777

The problem was that the code was always assuming the Hour value was reported at bottom of the hour, and not checking if it was bottom of the hour or top of the hour.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.
  • This change requires updating the PySAM files via export_config. Please see When do the PySAM files need to be regenerated?

@dguittet dguittet requested a review from mjprilliman December 6, 2024 20:26
@dguittet dguittet merged commit 76f29cb into develop Dec 6, 2024
2 of 8 checks passed
@dguittet dguittet deleted the solar_interpolation_macro branch December 6, 2024 22:56
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 10, 2024
@cpaulgilman cpaulgilman added this to the SAM Fall 2024 Release milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with Solar Resource Interpolation Macro
3 participants