Update clang-format version to the latest (19.1.7) (#3782)

Get new version at: https://pypi.org/project/clang-format/ The new version seems to format better, see diff.
NVIDIA · Jan 29, 2025 · 7d94abe · 7d94abe
1 parent 76fec33
commit 7d94abe
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 18 deletions.
diff --git a/.lintrunner.toml b/.lintrunner.toml
@@ -44,7 +44,7 @@ init_command = [
     'python3',
     'tools/linter/adapters/pip_init.py',
     '--dry-run={{DRYRUN}}',
-    'clang-format==18.1.8',
+    'clang-format==19.1.7',
 ]
 is_formatter = true
 

diff --git a/csrc/polymorphic_value.h b/csrc/polymorphic_value.h
@@ -201,7 +201,7 @@ class StructHandle {
 
   template <typename Ret, typename Class>
   inline std::enable_if_t<std::is_base_of_v<Struct, Class>, Ret&> operator->*(
-      Ret Class::*member) const {
+      Ret Class::* member) const {
     return as<Class>().*member;
   }
 

diff --git a/lib/dynamic_type/src/dynamic_type/dynamic_type.h b/lib/dynamic_type/src/dynamic_type/dynamic_type.h
@@ -249,8 +249,7 @@ struct DynamicType {
   constexpr DynamicType(T&& value) : value(std::forward<T>(value)) {}
 
   template <
-      template <typename...>
-      typename Template,
+      template <typename...> typename Template,
       typename ItemT,
       typename = std::enable_if_t<
           is_candidate_type<Template<DynamicType>> &&
@@ -316,16 +315,14 @@ struct DynamicType {
   }
 
   template <
-      template <typename...>
-      typename Template,
+      template <typename...> typename Template,
       typename = std::enable_if_t<is_candidate_type<Template<DynamicType>>>>
   constexpr const Template<DynamicType>& as() const {
     return as<Template<DynamicType>>();
   }
 
   template <
-      template <typename...>
-      typename Template,
+      template <typename...> typename Template,
       typename = std::enable_if_t<is_candidate_type<Template<DynamicType>>>>
   constexpr Template<DynamicType>& as() {
     return as<Template<DynamicType>>();
@@ -344,8 +341,7 @@ struct DynamicType {
   }
 
   template <
-      template <typename...>
-      typename Template,
+      template <typename...> typename Template,
       typename ItemT,
       typename = std::enable_if_t<
           is_candidate_type<Template<DynamicType>> && can_cast_to<ItemT>>>
@@ -488,7 +484,7 @@ struct DynamicType {
       typename Ret,                                                            \
       typename Class,                                                          \
       typename = std::enable_if_t<is_candidate_type<Class>>>                   \
-  constexpr decltype(auto) operator->*(Ret Class::*member) __const {           \
+  constexpr decltype(auto) operator->*(Ret Class::* member) __const {          \
     /* Use decltype(auto) instead of auto as return type so that references */ \
     /* and qualifiers are preserved*/                                          \
     if constexpr (std::is_function_v<Ret>) {                                   \

diff --git a/lib/dynamic_type/test/member.cpp b/lib/dynamic_type/test/member.cpp
@@ -41,19 +41,19 @@ struct E {
 struct CD {
   std::variant<C, D> v;
 
-  constexpr const int& operator->*(int C::*member) const {
+  constexpr const int& operator->*(int C::* member) const {
     return std::get<C>(v).*member;
   }
 
-  constexpr const int& operator->*(int D::*member) const {
+  constexpr const int& operator->*(int D::* member) const {
     return std::get<D>(v).*member;
   }
 
-  constexpr int& operator->*(int C::*member) {
+  constexpr int& operator->*(int C::* member) {
     return std::get<C>(v).*member;
   }
 
-  constexpr int& operator->*(int D::*member) {
+  constexpr int& operator->*(int D::* member) {
     return std::get<D>(v).*member;
   }
 };

diff --git a/lib/dynamic_type/test/opcheck.cpp b/lib/dynamic_type/test/opcheck.cpp
@@ -169,7 +169,7 @@ static_assert(!opcheck<int>->value());
 
 // Arrow star operator
 struct OverloadArrowStar {
-  auto operator->*(int OverloadArrowStar::*memberPtr) const -> int* {
+  auto operator->*(int OverloadArrowStar::* memberPtr) const -> int* {
     return nullptr;
   }
 };

diff --git a/runtime/fused_welford_helper.cu b/runtime/fused_welford_helper.cu
@@ -18,8 +18,7 @@ template <
     int NumVals,
     typename DataTypeT,
     typename IndexTypeT,
-    template <int, typename>
-    typename MakeTuple>
+    template <int, typename> typename MakeTuple>
 struct WelfordTripletTuple {
   static constexpr int num_vals = NumVals;
   using DataType = DataTypeT;