Justfile improvements #274
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malcolmgreaves
requested review from
dorotat-nv,
farhadrgh,
gwarmstrong,
jomitchellnv,
jstjohn,
pstjohn,
skothenhill-nv,
ohadmo and
trvachov
as code owners
malcolmgreaves
changed the title
bionemo_data_downloadbionemo_data_download; build-{dev,release} skip if exists; setup docker NGC login
|
/build-ci |
|
Wait, why though? Do we really want users to pre-download all the test data? |
jstjohn
reviewed
Oct 8, 2024
Comment on lines
249
to
252
| download_all = args.all | ||
| list_resources = args.list_resources | ||
| artifact_name = args.artifact_name | ||
| source = args.source |
There was a problem hiding this comment.
you could even type annotate these
jstjohn
reviewed
Oct 8, 2024
jstjohn
reviewed
Oct 8, 2024
malcolmgreaves
changed the title
bionemo_data_download; build-{dev,release} skip if exists; setup docker NGC login
malcolmgreaves
changed the title
malcolmgreaves
force-pushed
the
mg/just++
branch
from
4690b54
to
5089bf5
Compare
|
/build-ci |
tshimko-nv
approved these changes
Oct 24, 2024
|
/build-ci |
|
/build-ci |
pstjohn
approved these changes
Oct 29, 2024
|
For sure @pstjohn -- one thing that is convenient about justfiles is they can load |
|
/build-ci |
|
/build-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds several small improvements to the
justfile. Thebuild-{dev,release}commands will now skip the image build step if there is already an image with the same tag present locally.The Justfile's
setupcommand now logs the user into the NGC image repository. Login uses theNGC_API_KEYvalue from the user's.envfile.