Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Holodeck GitHub Action #20

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Create Holodeck GitHub Action #20

merged 7 commits into from
Feb 28, 2024

Conversation

ArangoGutierrez
Copy link
Collaborator

No description provided.

@ArangoGutierrez
Use go-version-file for go version in setup-go setp
17a77c2 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez ArangoGutierrez self-assigned this Feb 22, 2024
elezar
elezar reviewed Feb 22, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
elezar
elezar reviewed Feb 22, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
elezar
elezar reviewed Feb 22, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@ArangoGutierrez
Add Dockerfile for container gh action
e28e83e 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Add GitHub action to build image
4aabd1e 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Add missing license headers
03a83de 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Add GitHub action file
0c466f7 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez ArangoGutierrez marked this pull request as ready for review February 22, 2024 11:35
@ArangoGutierrez ArangoGutierrez added maintenance testing issue/PR to fix/edit/create/enhance a project unit/e2e test maintenance Issue/PR to create or address a team project management need and removed maintenance labels Feb 22, 2024
elezar
elezar reviewed Feb 23, 2024
View reviewed changes
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about leaking secrets into logs.

scripts/run.sh Show resolved Hide resolved
scripts/run.sh Outdated Show resolved Hide resolved
@ArangoGutierrez
Copy link
Collaborator Author

@elezar PTAL, I think is ready for another round

elezar
elezar reviewed Feb 26, 2024
View reviewed changes
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez.

I have some questions. They should not be blockers though.

.github/workflows/image.yml Show resolved Hide resolved
action.yml Show resolved Hide resolved
scripts/cleanup.sh Outdated Show resolved Hide resolved
scripts/run.sh Outdated Show resolved Hide resolved
scripts/run.sh Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
tariq1890
tariq1890 reviewed Feb 26, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@ArangoGutierrez
Add entrypoint and cleanup scripts for github action
7a6db4c 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Copy link
Collaborator Author

@elezar PTAL

elezar
elezar reviewed Feb 27, 2024
View reviewed changes
action.yml Outdated Show resolved Hide resolved
elezar
elezar reviewed Feb 27, 2024
View reviewed changes
action.yml Outdated Show resolved Hide resolved
elezar
elezar reviewed Feb 28, 2024
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
@ArangoGutierrez @elezar
Update action.yml
1e8d3af 
Co-authored-by: Evan Lezar <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Copy link
Collaborator Author

All comments addressed @elezar

@ArangoGutierrez ArangoGutierrez merged commit 22998dc into main Feb 28, 2024
3 checks passed
@ArangoGutierrez ArangoGutierrez deleted the ghaction branch February 28, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elezar elezar elezar approved these changes

@cdesiniotis cdesiniotis Awaiting requested review from cdesiniotis cdesiniotis is a code owner

@tariq1890 tariq1890 Awaiting requested review from tariq1890 tariq1890 is a code owner

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
maintenance Issue/PR to create or address a team project management need testing issue/PR to fix/edit/create/enhance a project unit/e2e test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArangoGutierrez @elezar @tariq1890