Add support for custom events fired by clicking on notifications #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhamp
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Seems really reasonable to me! Would you be up for implementing the 'client' side too?
|
@simonhamp possibly, what's needed for that? I haven't been working on any nativephp projects in a while. |
|
@LukeTowers no worries. It just needs a way to pass the custom event name down through the request to the Electron side. If you're not actively on this right now, I can pick it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resubmission of NativePHP/electron-plugin#4