Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from setup.py to pyproject.toml with Poetry for package management #233

Merged
merged 27 commits into from
Feb 5, 2025

Conversation

sibocw
Copy link
Contributor

@sibocw sibocw commented Feb 5, 2025

Description

Switch from setup.py to pyproject.toml with Poetry for package management.

Does this address any currently open issues?

[list open issues here]

@sibocw sibocw changed the title Switch from setup.py to pyproject.toml for package management Switch from setup.py to pyproject.toml with Poetry for package management Feb 5, 2025
@sibocw sibocw changed the base branch from main to dev-v1.2.0 February 5, 2025 13:47
@sibocw
Copy link
Contributor Author

sibocw commented Feb 5, 2025

Note: PyTest first finds all the files and functions that start with test and start importing stuff, and only then does it check if the tests should be included based on the command line input. I'm not sure exactly how this works but here's the problem:

  1. On Macs with Intel chips, we must not run the unit tests in the provided examples because PyTorch doesn't support the hardware.
  2. Therefore, on these runners, we should only run basic tests that are under flygym/tests.
  3. But PyTest tries to import stuff from the examples anyway.

I fixed it by specifically asking it to run tests only in a single file: flygym/tests/test_basic.py. This worked. This also didn't work. I'm just going to remove the test now.

@sibocw sibocw merged commit 1013452 into dev-v1.2.0 Feb 5, 2025
16 checks passed
@sibocw sibocw deleted the switch-to-poetry branch February 5, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant