Decide numpy version based on platform #234
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torch=2.2.2
is the max supported version for intel macs which is incompatible withnumpy>=2
#231).Therefore, here I tried to conditionally specify using NumPy 1.* for Apple Silicon Macs and NumPy 2.* otherwise. This is similar to @Dominic-DallOsto's commit 376fe72, but now that we have moved from
setup.py
topyproject.yaml
, we need to redo it inpyproject.yaml
.However, this made the dependency resolution process (
poetry lock
) EXTREMELY slow (~35 minutes instead of a few seconds). I don't know why. Until we figure it out, I suggest that we just requirenumpy<2.0
for all platforms. The aim of this PR is therefore to retain what I changed but not to merge it into ongoing v1.2.0 development.Does this address any currently open issues?
#231