Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain and manifest to Rust 1.70.0 #130

Closed

Conversation

mikedotexe
Copy link

I noticed this error when opening the repo:

Screenshot 2024-01-19 at 8 37 40 AM

So updated Cargo.toml and rust-toolchain in the project root from 1.69.0 » 1.70.0

This repo looks really amazing, btw, bravo!

@mooori
Copy link
Contributor

mooori commented Jan 23, 2024

Thank you for bringing this up! We have workarounds for building with 1.69 and use them in CI, but missed to highlight them to users.

We cannot yet bump the MSRV as some users of this crate still need to use Rust 1.69.0. To prevent issues like this, I’ve opened #131. After it lands, user with a toolchain >= 1.70.0 should not hit this issue anymore, as the override is removed from rust-toolchain (ref).

@mooori
Copy link
Contributor

mooori commented Jan 23, 2024

Closing as #131 has landed, which should resolve the issue for users with Rust >= 1.70. Users that need to use Rust < 1.70 can refer to #132.

@mooori mooori closed this Jan 23, 2024
@mikedotexe mikedotexe deleted the update-rust-ver-1.70.0 branch February 2, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants