feat(FullAccessKeyFallback)!: remove the plugin #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
FullAccessKeyFallbacksince there are some issues with its design: external-4, external-6, external-23, external-30.The default implementation of
FullAccessKeyFallbackconsists only of a few lines of code. If smart contract devs need this behavior, it makes more sense for them to implement their own solution tailored to their use-case.Breaking changes
It removes a plugin: the
FullAccessKeyFallbacktrait and its default implementation.Additional changes
FullAccessKeyFallbackwas the last plugin that was included inexamples/. As the corresponding examples were removed, some code became unused, which is removed in this PR. This allows deleting theexamples/directory.The contracts in
near-plugins-derive/tests/contractsserve as examples now (ref. #48).