-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement debug report generation and adjust issue template #674
base: master
Are you sure you want to change the base?
Conversation
I don't have any time at the moment to check any code or comments above, but saw the mention of needing Linux support, so I will have a look this weekend. |
I will have time tomorrow (Sunday) to check this out on Linux. Is there anything in particular you want me to look at or help with? As for how to launch it on Linux, we can use |
…s, +packet loss, +linux sh and +requirements
Ive added a |
@O-J1 Alright, here we go. First of all, fantastic work creating this debug report framework. There are some small things we should fix but overall it's a very good tool and a superb initiative from you. Thank you. I'll start a code review with the bugs. They are all minor. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review and Linux testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found an issue with processor name fetching on Linux.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It suddenly hit me that there's a big bug for non-English users. Fix provided.
…ug.sh as reccomended, added space in reqs and I attempted to fix raised issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is shaping up super nicely! I am so sorry to have found some issues. Back and forth changes are never fun as a contributor, so please don't overwork yourself. I've got a few bugs, found some solutions for Mac users, etc. It's worth looking through these, but after these changes I don't see anything else in its current state. ❤️
…nstructions, fixed typos and version for Linux.
Heres a WSL2 output this time from the latest commit. I have further changes not yet committed that added type hints, classes and tests but I am not sure if thats overkill, waiting to hear Neros thoughts on the current commit. Im quite happy with it as of commit |
As discussed on Discord, this PR adds functionality to generate debug logs via running on
export_debug.bat
.Users can then upload the resulting
debug_report.log
when reporting issues on GitHub, great for less experienced users.A few notes on the implementation and disclaimers:
It would be great if someone could test this on Linux to confirm cross-platform compatibility.