Add tool to fetch latest EC2 pricing from AWS API #102
Conversation
Introduces a tool to automatically fetch EC2 pricing and inject into the hardware pricing information for AWS. Also, update the hardware profile loading to allow multiple files, read by lexicographical sort.
service_capacity_modeling/hardware/profiles/pricing/aws/3yr-reserved_zz-overrides.json
Outdated
Show resolved
Hide resolved
jasonk000
force-pushed
the
jkoch/fetch-pricing
branch
from
1443aec to
b80bc86
Compare
This is awesome! let's chat about extending multi-file to shapes as well. |
| "g5.4xlarge": { | ||
| "annual_cost": 5349.0 | ||
| }, | ||
| "c4.xlarge": { |
There was a problem hiding this comment.
Can this file be sorted lexiographically? I think there is an option in json dump to write in source order and then we can just insert in lexiographic order.
There was a problem hiding this comment.
Can do a sort... more of a meta discussion though:
My thinking was that different files can do different chunks of data, so we can add a _rds.json to store the rds pricing data. It's just the load stage that has to be able to blend the files programmatically.
If you wanted to insert shape data, with manual input, in different files, we could apply a similar treatment to the loading of shapes/aws.json data, and combine instance data. For ex, shapes/aws_sizes, shapes/aws_fio, shapes/aws_iperf, shapes/.... could all be manually maintained distinctly, and blended at load time.
An ideal end-state would be absolutely as much as possible should be generated by tooling, and a minimum amount of cognitive effort to apply manual inputs. The code should take care of loading and combining files correctly, rather than pushing the thinking to people manually typing it in.
All that is to say, I don't think this file should ever be modified by a human, so I'm not sure the value of sorting it. Maybe I've misunderstood! Let me know what you're thinking.
service_capacity_modeling/hardware/profiles/pricing/aws/3yr-reserved_zz-overrides.json
Outdated
Show resolved
Hide resolved
|
Will follow up on the test change. Thank you I am stoked to get this automated. |
Introduces a tool to automatically fetch EC2 pricing and inject into the hardware pricing information for AWS. Also, update the hardware profile loading to allow multiple files, read by lexicographical sort.