Merge pull request #742 from tulikabhatt/fix_boolean_decoder

Remove trailing/leading whitespace in boolean decoder
Netflix · Jan 27, 2025 · 9ca8b2f · 9ca8b2f
2 parents 56adbe4 + 6c71747
commit 9ca8b2f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/...aius2-core/src/main/java/com/netflix/archaius/converters/DefaultTypeConverterFactory.java b/...aius2-core/src/main/java/com/netflix/archaius/converters/DefaultTypeConverterFactory.java
@@ -35,6 +35,7 @@ public final class DefaultTypeConverterFactory implements TypeConverter.Factory
     public static final DefaultTypeConverterFactory INSTANCE = new DefaultTypeConverterFactory();
 
     private static Boolean convertBoolean(String value) {
+        value = value.trim();
         if (value.equalsIgnoreCase("true") || value.equalsIgnoreCase("yes") || value.equalsIgnoreCase("on")) {
             return Boolean.TRUE;
         }

diff --git a/archaius2-core/src/test/java/com/netflix/archaius/DefaultDecoderTest.java b/archaius2-core/src/test/java/com/netflix/archaius/DefaultDecoderTest.java
@@ -176,4 +176,11 @@ public void testTypeConverterRegistry() {
         class Foo {}
         assertFalse(DefaultDecoder.INSTANCE.get(Foo.class).isPresent());
     }
+
+    @Test
+    public void testConvertBoolean() {
+        DefaultDecoder decoder = DefaultDecoder.INSTANCE;
+        boolean flag = decoder.decode(boolean.class, " true ");
+        assertTrue(flag);
+    }
 }