Consistently handle proxied beans in DgsSchemaProvider #1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilink
force-pushed
the
consistent-proxy-handling
branch
2 times, most recently
from
99603ae to
e2fa6db
Compare
srinivasankavitha
approved these changes
Jan 19, 2024
Ensure that we are consistently handling proxied beans in DgsSchemaProvider by refactoring some of the logic to retrieve annotated methods; after fetching DgsComponent-annotated beans, use a new internal wrapper class, DgsBean, that correctly handles proxies, and includes a helper method to retrieve all methods decorated with a particular annotation. In addition to making the handling consistent, moving the logic to the DgsBean wrapper class avoids repeated unwrapping of proxies and allocations.
kilink
force-pushed
the
consistent-proxy-handling
branch
from
e2fa6db to
39ae61a
Compare
There was an issue reported with proxies here: #1163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we are consistently handling proxied beans in DgsSchemaProvider by refactoring some of the logic to retrieve annotated methods; after fetching DgsComponent-annotated beans, use a new internal wrapper class, DgsBean, that correctly handles proxies, and includes a helper method to retrieve all methods decorated with a particular annotation. In addition to making the handling consistent, moving the logic to the DgsBean wrapper class avoids repeated unwrapping of proxies and allocations.
Fixes #1163