Allow connection directive to be applied to Unions and Interfaces #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DgsPaginationTypeDefinitionRegistry generated a connection directive which could only be applied to Object types; update it to allow Union and Interfaces as well. There were tests for this scenario but they didn't catch the problem because they never built a GraphQLSchema. To avoid such issues, switch all of the tests to fully build a GraphQLSchema.
srinivasankavitha
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DgsPaginationTypeDefinitionRegistry generated a connection directive which could only be applied to Object types; update it to allow Union and Interfaces as well.
There were tests for this scenario but they didn't catch the problem because they never built a GraphQLSchema. To avoid such issues, switch all of the tests to fully build a GraphQLSchema.
Fixes #1317.