revert last changes

Netflix · Sep 17, 2024 · 491b043 · 491b043
1 parent 4df3b3f
commit 491b043
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 10 deletions.
diff --git a/...e/src/main/java/com/netflix/metacat/connector/hive/sql/HiveConnectorFastTableService.java b/...e/src/main/java/com/netflix/metacat/connector/hive/sql/HiveConnectorFastTableService.java
@@ -154,8 +154,7 @@ public TableInfo get(final ConnectorRequestContext requestContext, final Qualifi
                 && HiveTableUtil.isCommonView(info)) {
                 final String tableLoc = HiveTableUtil.getCommonViewMetadataLocation(info);
                 return hiveConnectorFastTableServiceProxy.getCommonViewTableInfo(name, tableLoc, info,
-                    new HiveTypeConverter(),
-                        connectorContext.getConfig().isIcebergCacheEnabled());
+                    new HiveTypeConverter(), connectorContext.getConfig().isIcebergCacheEnabled());
             }
             if (!connectorContext.getConfig().isIcebergEnabled() || !HiveTableUtil.isIcebergTable(info)) {
                 return info;

diff --git a/...rc/test/groovy/com/netflix/metacat/connector/hive/converters/HiveTypeConverterSpec.groovy b/...rc/test/groovy/com/netflix/metacat/connector/hive/converters/HiveTypeConverterSpec.groovy
@@ -13,12 +13,12 @@
 
 package com.netflix.metacat.connector.hive.converters
 
-import com.netflix.metacat.common.server.properties.Config
 import org.apache.iceberg.PartitionField
 import org.apache.iceberg.transforms.Identity
 import org.apache.iceberg.transforms.VoidTransform
 import org.apache.iceberg.Schema
 import org.apache.iceberg.types.Types
+import spock.lang.Shared
 import spock.lang.Specification
 import spock.lang.Unroll
 
@@ -28,11 +28,8 @@ import spock.lang.Unroll
  * @since 1.0.0
  */
 class HiveTypeConverterSpec extends Specification {
-    HiveTypeConverter converter;
-
-    def setup() {
-        this.converter = new HiveTypeConverter()
-    }
+    @Shared
+    HiveTypeConverter converter = new HiveTypeConverter()
 
     @Unroll
     def 'can convert "#typeString" to a presto type and back'(String typeString) {

diff --git a/metacat-functional-tests/metacat-test-cluster/docker-compose.yml b/metacat-functional-tests/metacat-test-cluster/docker-compose.yml
@@ -77,8 +77,7 @@ services:
                 -Dmetacat.parentChildRelationshipProperties.createEnabled=true
                 -Dmetacat.parentChildRelationshipProperties.getEnabled=true
                 -Dmetacat.parentChildRelationshipProperties.renameEnabled=true
-                -Dmetacat.parentChildRelationshipProperties.dropEnabled=true
-                -Dmetacat.partitionColumnProperties.omitVoidPartitionEnabled=true'
+                -Dmetacat.parentChildRelationshipProperties.dropEnabled=true'
         labels:
           - "com.netflix.metacat.oss.test"
           - "com.netflix.metacat.oss.test.war"