Skip to content

Commit

Permalink
fix test final
Browse files Browse the repository at this point in the history
  • Loading branch information
Giorgio Trettenero committed Dec 4, 2024
1 parent 8275c09 commit fd0085f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -86,11 +86,8 @@ public void delete(final ConnectorRequestContext context, final QualifiedName na
throw new DatabaseNotFoundException(name);
}
try {
System.out.println("BEFORE deleting polaris database " + name.getDatabaseName());
this.polarisStoreService.deleteDatabase(name.getDatabaseName());
System.out.println("AFTER deleting polaris database " + name.getDatabaseName());
} catch (DataIntegrityViolationException exception) {
System.out.println("CAUGHT THE DB DELETE ERROR");
if (exception.getCause() instanceof org.hibernate.exception.ConstraintViolationException) {
throw new DatabasePreconditionFailedException(
name,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package com.netflix.metacat.connector.polaris.store;


import com.netflix.metacat.common.server.connectors.exception.DatabasePreconditionFailedException;
import com.netflix.metacat.connector.polaris.common.PolarisUtils;
import com.netflix.metacat.connector.polaris.configs.PolarisPersistenceConfig;
import com.netflix.metacat.connector.polaris.store.entities.PolarisDatabaseEntity;
Expand All @@ -17,6 +16,7 @@
import org.springframework.boot.test.autoconfigure.orm.jpa.AutoConfigureDataJpa;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.dao.DataAccessException;
import org.springframework.dao.DataIntegrityViolationException;
import org.springframework.dao.OptimisticLockingFailureException;
import org.springframework.test.context.ActiveProfiles;
import org.springframework.test.context.junit.jupiter.SpringExtension;
Expand Down Expand Up @@ -138,7 +138,7 @@ public void testDbDeletionNoCascade() {
final PolarisDatabaseEntity dbEntity = createDB(dbName);
final PolarisTableEntity tblEntity = createTable(dbName, tblName);

Assertions.assertThrows(DatabasePreconditionFailedException.class, () ->
Assertions.assertThrows(DataIntegrityViolationException.class, () ->
polarisConnector.deleteDatabase(dbName));
Assert.assertTrue(polarisConnector.databaseExists(dbName));
}
Expand Down

0 comments on commit fd0085f

Please sign in to comment.