list table names with snapshot #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insyncoss
reviewed
Jan 8, 2024
| for (String tableName : polarisStoreService.getTables(name.getDatabaseName(), tableFilter)) { | ||
| for (String tableName : polarisStoreService.getTables(name.getDatabaseName(), | ||
| tableFilter, | ||
| 1000) |
There was a problem hiding this comment.
Could this constant in the code be made into a constant variable
| final List<String> tableNames = polarisStoreService.getTables( | ||
| name.getDatabaseName(), | ||
| "", | ||
| 1000); |
There was a problem hiding this comment.
Since names are smaller than the objects themselves, it might be more efficient to make the constant larger for names, maybe we can try 5k or 10k
There was a problem hiding this comment.
Looks like this one was missed, can you update it to read from config as well
| List<PolarisTableEntity> findAllTablesByDbNameAndTablePrefix( | ||
| String dbName, String tableNamePrefix, int pageSize); | ||
| List<?> findAllTablesByDbNameAndTablePrefix( | ||
| String dbName, String tableNamePrefix, int pageSize, boolean selectAll); |
There was a problem hiding this comment.
The selectAll name could be improved since the method name already has findAll so it could seem like it might not return the whole list, this could be renamed instead to selectNames or something similar
added 2 commits
January 8, 2024 17:29
insyncoss
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes list table names using the AS OF SYSTEM TIME semantics.