[kubernetes] Use KUBECONFIG if set #1716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savingoyal
requested changes
Feb 5, 2024
| elif os.getenv("KUBERNETES_SERVICE_HOST"): | ||
| # We are inside a pod, authenticate via ServiceAccount assigned to us | ||
| config.load_incluster_config() | ||
| else: |
There was a problem hiding this comment.
this might be a backwards incompatible change and will break many currently well functioning flows. do we expect KUBECONFIG env var to be always available?
There was a problem hiding this comment.
This could be made backward compatible if the original call to config.load_kube_config in the else case is retained instead of throwing the KubernetesException.
…t, default to loading kubeconfig to keep current behaviour
savingoyal
reviewed
Feb 5, 2024
madhur-ob
approved these changes
Feb 5, 2024
savingoyal
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1715
Not sure where to document this (it'd be useful for folks setting up their CI pipelines) - any ideas?