Improve receiptCommitment function with parallel processing (#2165)

core/receipt.go

@@ -1,6 +1,9 @@
 package core
 
 import (
+	"runtime"
+	"sync"
+
 	"github.com/NethermindEth/juno/core/crypto"
 	"github.com/NethermindEth/juno/core/felt"
 	"github.com/NethermindEth/juno/core/trie"
@@ -62,12 +65,32 @@ func messagesSentHash(messages []*L2ToL1Message) *felt.Felt {
 
 func receiptCommitment(receipts []*TransactionReceipt) (*felt.Felt, error) {
 	var commitment *felt.Felt
-
 	return commitment, trie.RunOnTempTriePoseidon(commitmentTrieHeight, func(trie *trie.Trie) error {
-		for i, receipt := range receipts {
-			receiptTrieKey := new(felt.Felt).SetUint64(uint64(i))
-			_, err := trie.Put(receiptTrieKey, receipt.hash())
-			if err != nil {
+		numWorkers := min(runtime.GOMAXPROCS(0), len(receipts))
+		results := make([]*felt.Felt, len(receipts))
+		var wg sync.WaitGroup
+		wg.Add(numWorkers)
+
+		jobs := make(chan int, len(receipts))
+		for idx := range receipts {
+			jobs <- idx
+		}
+		close(jobs)
+
+		for range numWorkers {
+			go func() {
+				defer wg.Done()
+				for i := range jobs {
+					results[i] = receipts[i].hash()
+				}
+			}()
+		}
+
+		wg.Wait()
+
+		for i, res := range results {
+			key := new(felt.Felt).SetUint64(uint64(i))
+			if _, err := trie.Put(key, res); err != nil {
 				return err
 			}
 		}

core/receipt_pkg_test.go

@@ -0,0 +1,98 @@
+package core
+
+import (
+	"slices"
+	"testing"
+
+	"github.com/NethermindEth/juno/core/felt"
+	"github.com/NethermindEth/juno/utils"
+	"github.com/stretchr/testify/require"
+)
+
+func BenchmarkReceiptCommitment(b *testing.B) {
+	fromHex := func(hex string) *felt.Felt {
+		b.Helper()
+		return utils.HexToFelt(b, hex)
+	}
+	// receipts were taken from sepolia block 35748
+	// we don't use adaptfeeder here because it causes cyclic import
+	baseReceipts := []*TransactionReceipt{
+		{
+			TransactionHash: fromHex("0x5ac644bbd6ae98d3be2d988439854e33f0961e24f349a63b43e16d172bfe747"),
+			Fee:             fromHex("0xd07af45c84550"),
+			Events: []*Event{
+				{
+					From: fromHex("0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7"),
+					Data: []*felt.Felt{
+						fromHex("0x472aa8128e01eb0df145810c9511a92852d62a68ba8198ce5fa414e6337a365"),
+						fromHex("0x1176a1bd84444c89232ec27754698e5d2e7e1a7f1539f12027f28b23ec9f3d8"),
+						fromHex("0xd07af45c84550"),
+						fromHex("0x0"),
+					},
+					Keys: []*felt.Felt{
+						fromHex("0x99cd8bde557814842a3121e8ddfd433a539b8c9f14bf31ebf108d12e6196e9"),
+					},
+				},
+			},
+			ExecutionResources: &ExecutionResources{
+				BuiltinInstanceCounter: BuiltinInstanceCounter{
+					Pedersen:   16,
+					RangeCheck: 157,
+					Ecsda:      1,
+					Poseidon:   4,
+				},
+				MemoryHoles: 0,
+				Steps:       3950,
+				DataAvailability: &DataAvailability{
+					L1Gas:     0,
+					L1DataGas: 192,
+				},
+				TotalGasConsumed: &GasConsumed{
+					L1Gas:     117620,
+					L1DataGas: 192,
+				},
+			},
+		},
+		{
+			Fee: fromHex("0x471426f16c4330"),
+			Events: []*Event{
+				{
+					From: fromHex("0x49d36570d4e46f48e99674bd3fcc84644ddd6b96f7c741b1562b82f9e004dc7"),
+					Data: []*felt.Felt{
+						fromHex("0x472aa8128e01eb0df145810c9511a92852d62a68ba8198ce5fa414e6337a365"),
+						fromHex("0x1176a1bd84444c89232ec27754698e5d2e7e1a7f1539f12027f28b23ec9f3d8"),
+						fromHex("0x471426f16c4330"),
+						fromHex("0x0"),
+					},
+					Keys: []*felt.Felt{
+						fromHex("0x99cd8bde557814842a3121e8ddfd433a539b8c9f14bf31ebf108d12e6196e9"),
+					},
+				},
+			},
+			ExecutionResources: &ExecutionResources{
+				BuiltinInstanceCounter: BuiltinInstanceCounter{
+					Pedersen:   16,
+					RangeCheck: 157,
+					Ecsda:      1,
+					Poseidon:   4,
+				},
+				Steps: 3950,
+				DataAvailability: &DataAvailability{
+					L1Gas:     0,
+					L1DataGas: 192,
+				},
+				TotalGasConsumed: &GasConsumed{
+					L1Gas:     641644,
+					L1DataGas: 192,
+				},
+			},
+			TransactionHash: fromHex("0x21bc0afe54123b946855e1bf9389d943313df5c5c396fbf0630234a44f6f592"),
+		},
+	}
+	receipts := slices.Repeat(baseReceipts, 100)
+	b.ResetTimer()
+	for i := 0; i < b.N; i++ {
+		_, err := receiptCommitment(receipts)
+		require.NoError(b, err)
+	}
+}