Fix linter issues

NethermindEth · Jul 29, 2024 · 3b9e643 · 3b9e643
1 parent 6e20a05
commit 3b9e643
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/adapters/p2p2core/receipt.go b/adapters/p2p2core/receipt.go
@@ -34,6 +34,7 @@ func AdaptReceipt(r *spec.Receipt, txHash *felt.Felt) *core.TransactionReceipt {
 		TransactionHash:    txHash,
 		Reverted:           common.RevertReason != nil, // todo is it correct?
 		RevertReason:       common.GetRevertReason(),
+		TotalGasConsumed:   nil, // todo(kirill) set field after spec update
 	}
 }
 

diff --git a/core/receipt.go b/core/receipt.go
@@ -27,12 +27,7 @@ type TransactionReceipt struct {
 func (r *TransactionReceipt) Hash() (*felt.Felt, error) {
 	revertReasonHash := &felt.Zero
 	if r.Reverted {
-		// todo remove error because it's unneccessary
-		var err error
-		revertReasonHash, err = crypto.StarknetKeccak([]byte(r.RevertReason))
-		if err != nil {
-			return nil, err
-		}
+		revertReasonHash = crypto.StarknetKeccak([]byte(r.RevertReason))
 	}
 
 	var totalGasConsumed GasConsumed

diff --git a/core/receipt_pkg_test.go b/core/receipt_pkg_test.go
@@ -2,12 +2,13 @@ package core
 
 import (
 	"encoding/binary"
+	"testing"
+
 	"github.com/NethermindEth/juno/core/felt"
 	"github.com/NethermindEth/juno/utils"
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"testing"
 )
 
 func TestReceiptHash(t *testing.T) {