Fix linter issues

adapters/p2p2core/receipt.go

@@ -34,6 +34,7 @@ func AdaptReceipt(r *spec.Receipt, txHash *felt.Felt) *core.TransactionReceipt {
 		TransactionHash:    txHash,
 		Reverted:           common.RevertReason != nil, // todo is it correct?
 		RevertReason:       common.GetRevertReason(),
+		TotalGasConsumed:   nil, // todo(kirill) set field after spec update
 	}
 }
 
@@ -52,7 +53,7 @@ func adaptExecutionResources(er *spec.Receipt_ExecutionResources) *core.Executio
 			Keccak:       uint64(er.GetBuiltins().GetKeccak()),
 			Poseidon:     uint64(er.GetBuiltins().GetPoseidon()),
 			SegmentArena: 0, // todo(kirill) recheck
-			// todo(kirill) update spec for 0.13.2
+			// todo(kirill) set fields after spec update
 			AddMod:       0,
 			MulMod:       0,
 			RangeCheck96: 0,

cmd/juno/juno.go

@@ -81,7 +81,6 @@ const (
 	callMaxStepsF           = "rpc-call-max-steps"
 	corsEnableF             = "rpc-cors-enable"
 	versionedConstantsFileF = "versioned-constants-file"
-	vmConcurrencyModeF      = "vm-concurrency-mode"
 
 	defaultConfig                   = ""
 	defaulHost                      = "localhost"
@@ -118,7 +117,6 @@ const (
 	defaultGwTimeout                = 5 * time.Second
 	defaultCorsEnable               = false
 	defaultVersionedConstantsFile   = ""
-	defaultVMConcurrencyModeF       = false
 
 	configFlagUsage                       = "The YAML configuration file."
 	logLevelFlagUsage                     = "Options: trace, debug, info, warn, error."
@@ -169,7 +167,6 @@ const (
 		"The upper limit is 4 million steps, and any higher value will still be capped at 4 million."
 	corsEnableUsage             = "Enable CORS on RPC endpoints"
 	versionedConstantsFileUsage = "Use custom versioned constants from provided file"
-	vmConcurrencyModeUsage      = "Use concurrent execution in VM"
 )
 
 var Version string
@@ -353,7 +350,6 @@ func NewCmd(config *node.Config, run func(*cobra.Command, []string) error) *cobr
 	junoCmd.Flags().Duration(gwTimeoutF, defaultGwTimeout, gwTimeoutUsage)
 	junoCmd.Flags().Bool(corsEnableF, defaultCorsEnable, corsEnableUsage)
 	junoCmd.Flags().String(versionedConstantsFileF, defaultVersionedConstantsFile, versionedConstantsFileUsage)
-	junoCmd.Flags().Bool(vmConcurrencyModeF, defaultVMConcurrencyModeF, vmConcurrencyModeUsage)
 	junoCmd.MarkFlagsMutuallyExclusive(p2pFeederNodeF, p2pPeersF)
 
 	junoCmd.AddCommand(GenP2PKeyPair())

core/receipt.go

@@ -27,12 +27,7 @@ type TransactionReceipt struct {
 func (r *TransactionReceipt) Hash() (*felt.Felt, error) {
 	revertReasonHash := &felt.Zero
 	if r.Reverted {
-		// todo remove error because it's unneccessary
-		var err error
-		revertReasonHash, err = crypto.StarknetKeccak([]byte(r.RevertReason))
-		if err != nil {
-			return nil, err
-		}
+		revertReasonHash = crypto.StarknetKeccak([]byte(r.RevertReason))
 	}
 
 	var totalGasConsumed GasConsumed

core/receipt_pkg_test.go

@@ -2,12 +2,13 @@ package core
 
 import (
 	"encoding/binary"
+	"testing"
+
 	"github.com/NethermindEth/juno/core/felt"
 	"github.com/NethermindEth/juno/utils"
 	"github.com/ethereum/go-ethereum/common"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"testing"
 )
 
 func TestReceiptHash(t *testing.T) {

node/node.go

@@ -86,8 +86,6 @@ type Config struct {
 
 	GatewayAPIKey  string        `mapstructure:"gw-api-key"`
 	GatewayTimeout time.Duration `mapstructure:"gw-timeout"`
-
-	VMConcurrencyMode bool `mapstructure:"vm-concurrency-mode"`
 }
 
 type Node struct {
@@ -174,7 +172,7 @@ func New(cfg *Config, version string) (*Node, error) { //nolint:gocyclo,funlen
 		services = append(services, synchronizer)
 	}
 
-	throttledVM := NewThrottledVM(vm.New(cfg.VMConcurrencyMode, log), cfg.MaxVMs, int32(cfg.MaxVMQueue))
+	throttledVM := NewThrottledVM(vm.New(false, log), cfg.MaxVMs, int32(cfg.MaxVMQueue))
 
 	var syncReader sync.Reader = &sync.NoopSynchronizer{}
 	if synchronizer != nil {

vm/vm_test.go

@@ -18,8 +18,6 @@ import (
 )
 
 func TestV0Call(t *testing.T) {
-	t.Skip("todo fix")
-
 	testDB := pebble.NewMemTest(t)
 	txn, err := testDB.NewTransaction(true)
 	require.NoError(t, err)
@@ -82,8 +80,6 @@ func TestV0Call(t *testing.T) {
 }
 
 func TestV1Call(t *testing.T) {
-	t.Skip("for now")
-
 	testDB := pebble.NewMemTest(t)
 	txn, err := testDB.NewTransaction(true)
 	require.NoError(t, err)
@@ -154,8 +150,6 @@ func TestV1Call(t *testing.T) {
 }
 
 func TestCall_MaxSteps(t *testing.T) {
-	t.Skip()
-
 	testDB := pebble.NewMemTest(t)
 	txn, err := testDB.NewTransaction(true)
 	require.NoError(t, err)