block's protocol version verification checks only the major part of t…

…he version

blockchain/blockchain.go

@@ -53,7 +53,7 @@ type Reader interface {
 
 var (
 	ErrParentDoesNotMatchHead = errors.New("block's parent hash does not match head block hash")
-	supportedStarknetVersion  = semver.MustParse("0.13.3")
+	SupportedStarknetVersion  = semver.MustParse("0.13.3")
 )
 
 func checkBlockVersion(protocolVersion string) error {
@@ -62,7 +62,8 @@ func checkBlockVersion(protocolVersion string) error {
 		return err
 	}
 
-	if blockVer.GreaterThan(supportedStarknetVersion) {
+	// We only care about major version changes ignoring minor and patch
+	if blockVer.Major() > SupportedStarknetVersion.Major() {
 		return errors.New("unsupported block version")
 	}
 

blockchain/blockchain_test.go

@@ -155,6 +155,23 @@ func TestVerifyBlock(t *testing.T) {
 		require.EqualError(t, chain.Store(mainnetBlock0, &emptyCommitments, mainnetStateUpdate0, nil), "unsupported block version")
 	})
 
+	t.Run("only difference in major protocol version is checked", func(t *testing.T) {
+		ver := blockchain.SupportedStarknetVersion
+		majorBumped, minorBUmped, patchBumped := ver.IncMajor(), ver.IncMinor(), ver.IncPatch()
+
+		// mismatch at patch is ignored
+		mainnetBlock0.ProtocolVersion = patchBumped.String()
+		require.NoError(t, chain.VerifyBlock(mainnetBlock0))
+
+		// mismatch at minor is ignored
+		mainnetBlock0.ProtocolVersion = minorBUmped.String()
+		require.NoError(t, chain.VerifyBlock(mainnetBlock0))
+
+		// mismatch at major cause an error
+		mainnetBlock0.ProtocolVersion = majorBumped.String()
+		require.EqualError(t, chain.VerifyBlock(mainnetBlock0), "unsupported block version")
+	})
+
 	t.Run("no error with no version string", func(t *testing.T) {
 		mainnetBlock0.ProtocolVersion = ""
 		require.NoError(t, chain.Store(mainnetBlock0, &emptyCommitments, mainnetStateUpdate0, nil))