Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change juno db path in gitignore #2243

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

weiihann
Copy link
Contributor

Putting juno/ in .gitignore will effectively ignore all the files in cmd/juno also. This gets annoying :(

@weiihann weiihann requested a review from derrix060 October 28, 2024 09:40
@weiihann weiihann force-pushed the weiihann/fix-juno-gitignore branch from 3239152 to e316d08 Compare October 28, 2024 09:41
@weiihann weiihann requested a review from kirugan October 28, 2024 09:43
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.68%. Comparing base (b37ef1a) to head (e316d08).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2243      +/-   ##
==========================================
+ Coverage   75.63%   75.68%   +0.04%     
==========================================
  Files         104      104              
  Lines       11102    11102              
==========================================
+ Hits         8397     8402       +5     
+ Misses       2073     2069       -4     
+ Partials      632      631       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wojciechos wojciechos merged commit 5cd51d8 into main Oct 28, 2024
12 checks passed
@wojciechos wojciechos deleted the weiihann/fix-juno-gitignore branch October 28, 2024 10:06
pnowosie pushed a commit that referenced this pull request Nov 5, 2024
pnowosie pushed a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants