Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block.hash 0.13.4 calculation #2361

Merged
merged 8 commits into from
Jan 9, 2025
Merged

Add block.hash 0.13.4 calculation #2361

merged 8 commits into from
Jan 9, 2025

Conversation

kirugan
Copy link
Contributor

@kirugan kirugan commented Jan 7, 2025

No description provided.

@codecov Codecov
Copy link

codecov bot commented Jan 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.17391% with 9 lines in your changes missing coverage. Please review.

Project coverage is 74.65%. Comparing base (2653ae9) to head (601dc0f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/block.go 89.77% 6 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2361      +/-   ##
==========================================
+ Coverage   74.52%   74.65%   +0.12%     
==========================================
  Files         110      110              
  Lines       11908    12012     +104     
==========================================
+ Hits         8875     8968      +93     
- Misses       2343     2351       +8     
- Partials      690      693       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rodrigo-pino
rodrigo-pino reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@rodrigo-pino rodrigo-pino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Cross checked with the pre-release notes and it matches. I believe the only thing missing is a couple of tests

core/block.go Outdated Show resolved Hide resolved
rpc/transaction.go Outdated Show resolved Hide resolved
starknet/transaction.go Outdated Show resolved Hide resolved
core/transaction.go Outdated Show resolved Hide resolved
core/transaction.go Outdated Show resolved Hide resolved
@kirugan kirugan marked this pull request as ready for review January 8, 2025 23:27
@kirugan kirugan merged commit f743e37 into main Jan 9, 2025
13 checks passed
@kirugan kirugan deleted the kirugan/block-hash-0.13.4 branch January 9, 2025 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnkushinDaniil AnkushinDaniil AnkushinDaniil approved these changes

@rodrigo-pino rodrigo-pino rodrigo-pino approved these changes

@IronGauntlets IronGauntlets IronGauntlets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirugan @IronGauntlets @rodrigo-pino @AnkushinDaniil