Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getTransactionStatus rpc response #2367

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Conversation

weiihann
Copy link
Contributor

Fixes #2366

@weiihann weiihann force-pushed the weiihann/fix-v070-txnstatus branch from 3179eb4 to 2008a1b Compare January 13, 2025 10:02
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.63%. Comparing base (0fb6380) to head (8978b57).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rpc/transaction.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2367      +/-   ##
==========================================
- Coverage   74.69%   74.63%   -0.06%     
==========================================
  Files         110      110              
  Lines       12012    12021       +9     
==========================================
  Hits         8972     8972              
- Misses       2348     2353       +5     
- Partials      692      696       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weiihann weiihann merged commit 2a4add5 into main Jan 13, 2025
13 checks passed
@weiihann weiihann deleted the weiihann/fix-v070-txnstatus branch January 13, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failure_reason field in starknet_getTransactionStatus returned in v0_7
3 participants