Prevent panic in TransactionByHash for non-existent transactions #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkushinDaniil
approved these changes
Jan 14, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2373 +/- ##
==========================================
- Coverage 74.70% 74.67% -0.03%
==========================================
Files 110 110
Lines 12021 12024 +3
==========================================
- Hits 8980 8979 -1
Misses 2349 2349
- Partials 692 696 +4 ☔ View full report in Codecov by Sentry. |
wojciechos
force-pushed
the
wojciechos/fix-panic
branch
from
5131bee to
1760dc8
Compare
When searching for a transaction in the pending block, the code would continue to AdaptTransaction even if no matching transaction was found. This could lead to a panic when trying to adapt a nil transaction. Added a nil check and an early break from the loop to ensure we properly handle non-existent transactions with ErrTxnHashNotFound. Changes: - Add break statement to exit loop once matching transaction is found - Add explicit nil check for txn before attempting to adapt it - Return ErrTxnHashNotFound if no matching transaction is found
wojciechos
force-pushed
the
wojciechos/fix-panic
branch
from
1760dc8 to
3c1e532
Compare
IronGauntlets
approved these changes
Jan 14, 2025
|
nit: for the commit message I would recommend focusing on "what" and "why" while letting the code say "how". In my opinion, the changes in bullet points are unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the code could panic when attempting to adapt a nil transaction in the pending block. This ensures the function gracefully handles non-existent transactions by returning ErrTxnHashNotFound.