Refactor: Reuse rpcv6 juno_version handler for v7 and v8 #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rianhughes
approved these changes
Feb 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2471 +/- ##
==========================================
- Coverage 73.65% 73.63% -0.03%
==========================================
Files 137 137
Lines 16659 16652 -7
==========================================
- Hits 12271 12261 -10
- Misses 3526 3528 +2
- Partials 862 863 +1 ☔ View full report in Codecov by Sentry. |
rpc/handlers.go
Outdated
| @@ -197,7 +197,7 @@ func (h *Handler) MethodsV0_8() ([]jsonrpc.Method, string) { //nolint: funlen | |||
| }, | |||
| { | |||
| Name: "juno_version", | |||
| Handler: h.rpcv8Handler.Version, | |||
| Handler: h.rpcv6Handler.Version, | |||
There was a problem hiding this comment.
The Version method shouldn't be part of any rpc. It should be a property of the "Master Handler" defined in rpc/handlers.go and it should have that method. No need to have the info replicated in three different structs.
Note that this is an exception since "juno_version" is not part of any specs. Also, every rpc should still expose the "juno_version" rpc, but they should all point to the one defined in the "Master Handler".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpc pkg cleanup according to #2437
Reuse v6 handler for both v7 and v8