Refactor: Reuse v6 juno_unsubscribe handler for v7 and v8 (starknet_unsubscribe) #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2509 +/- ##
==========================================
+ Coverage 73.65% 73.82% +0.16%
==========================================
Files 137 137
Lines 16659 16620 -39
==========================================
- Hits 12271 12270 -1
+ Misses 3526 3490 -36
+ Partials 862 860 -2 ☔ View full report in Codecov by Sentry. |
rianhughes
approved these changes
Feb 24, 2025
infrmtcs
reviewed
Feb 27, 2025
| @@ -882,107 +882,6 @@ func TestSubscribePendingTxs(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestUnsubscribe(t *testing.T) { | |||
There was a problem hiding this comment.
These tests actually server the starknet_unsubscribe instead of juno_unsubscribe. I think we'll eventually deprecate juno_unsubscribe because it's not currently in v8, so we shouldn't move this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rpc pkg cleanup according to #2437
As side notes:
events_test.go's package name torpcv6instead ofrpcv6_testin order to accesshandler.subscriptionsin tests (as it was done in v8subscriptions_test.go).