Implement Goldilocks example #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cupicmarko
requested review from
ElijahVlasov,
Fantoni0,
maksimryndin,
ivolkg,
matthew-a-klein and
v0-e
ElijahVlasov
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Looks amazing! Can we also incorporate the recent changes from #143? Feel free to leave it for another PR tho
We can, I can update this PR with more comments, add missing prints and fix failing tests, after that update with yesterdays changes in new PR, and implement remaining rings in another PR |
ElijahVlasov
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.