-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor benchmarks #161
Refactor benchmarks #161
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments for clarity, diff is hard to read
I think it looks pretty cool! 💯 |
I have something that can filter benchmarks based on environment variables, I just have to verify it works and I'll push one commit |
awesome job, @cupicmarko! 👍 |
- Update bounds.sage to generate config.toml instead of macros.rs
7d58c74
to
34456f8
Compare
It was updated to allow filtering, also bounds.sage was updated based on @ivolkg changes. I've noticed that it takes significantly more time to compile and link benches because there is more benchmark tests, so for local running, I would suggest either building benches incrementally or linking dynamically, to reduce build time. |
Revamped benchmarks: