Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-padded dense MLEs sync #165

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Non-padded dense MLEs sync #165

merged 2 commits into from
Dec 18, 2024

Conversation

v0-e
Copy link
Member

@v0-e v0-e commented Dec 16, 2024 •
edited
Loading

Sync with non-padded dense MLE changes of stark-rings PR#2.

Cuts peak memory by about 75% and 25% for the scalar (S) and non-scalar (NS) E2E benches, respectively.
Affects performance of all sub-protocols and E2E. Namely,

  • linearization: -4% (S) -2% (NS);
  • decomposition: -30% (S) -7% (NS);
  • folding: -45% (S) -8% (NS);
  • E2E: -36% (S) - 7% (NS).

@v0-e v0-e mentioned this pull request Dec 16, 2024
Merged
@v0-e v0-e marked this pull request as ready for review December 18, 2024 11:56
@v0-e v0-e requested a review from ElijahVlasov December 18, 2024 11:56
@ElijahVlasov ElijahVlasov merged commit 4c00b2a into main Dec 18, 2024
5 checks passed
@ElijahVlasov ElijahVlasov deleted the ev/non-padded-dmle branch December 18, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElijahVlasov ElijahVlasov ElijahVlasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@v0-e @ElijahVlasov