Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add p2p test result dashboard #12

Closed
wants to merge 13 commits into from
Closed

Add p2p test result dashboard #12

wants to merge 13 commits into from

Conversation

wojciechos
Copy link
Contributor

No description provided.

@wojciechos
Add p2p testing dashboard
cbe4ac9
@wojciechos
Remove generating mocked data
9cc0dc8
@wojciechos
Store data in db
839887a
@wojciechos
Require ssl connections
ec1dd57
@wojciechos
Add compatibility matrix to main page
8edd234
@wojciechos
Revers displaying scenarios
33b313b
@wojciechos
Fix order in compatibility dashboard
326a449
@wojciechos
Improve visibility of the dashboard
e2cf98e
@wojciechos
Add madara and papyrus to compatibility matrix
04b05a3
@wojciechos
Change title of compatibility table
1b77a63
@wojciechos
feat: reverse node display direction in TestDetails
e00dd55 
Changed arrow direction from -> to <- and swapped node positions to show
target <- source instead of source -> target
@wojciechos
feat(ui): add directional indicators to P2P sync matrix
5ec30f4
@wojciechos
Add 'dashboard/' from commit '5ec30f4679778d79dfb5e0278ed95336f822200f'
94a26ca 
git-subtree-dir: dashboard
git-subtree-mainline: 59f539a
git-subtree-split: 5ec30f4
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 27, 2024
View reviewed changes
dashboard/src/server/index.js
Comment on lines +93 to +108
app.get('/events', async (req, res) => {
res.setHeader('Content-Type', 'text/event-stream');
res.setHeader('Cache-Control', 'no-cache');
res.setHeader('Connection', 'keep-alive');

try {
const result = await appPool.query('SELECT data FROM test_runs');
const initialData = result.rows.map(row => row.data);
res.write(`data: ${JSON.stringify({ type: 'initial', data: initialData })}\n\n`);
} catch (error) {
console.error('Error fetching initial data:', error);
}

clients.add(res);
req.on('close', () => clients.delete(res));
});

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.

Copilot Autofix AI 2 months ago

To fix the problem, we need to introduce rate limiting to the /events endpoint to prevent abuse and potential denial-of-service attacks. The best way to achieve this is by using the express-rate-limit middleware, which allows us to set a maximum number of requests that a client can make within a specified time window.

  1. Install the express-rate-limit package.
  2. Import the express-rate-limit package in the dashboard/src/server/index.js file.
  3. Create a rate limiter with appropriate settings (e.g., maximum of 100 requests per 15 minutes).
  4. Apply the rate limiter to the /events endpoint.
Suggested changeset 2
dashboard/src/server/index.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/dashboard/src/server/index.js b/dashboard/src/server/index.js
--- a/dashboard/src/server/index.js
+++ b/dashboard/src/server/index.js
@@ -5,2 +5,3 @@
 import dotenv from 'dotenv';
+import rateLimit from 'express-rate-limit';
 
@@ -76,2 +77,8 @@
 
+// Set up rate limiter: maximum of 100 requests per 15 minutes
+const limiter = rateLimit({
+  windowMs: 15 * 60 * 1000, // 15 minutes
+  max: 100, // max 100 requests per windowMs
+});
+
 const clients = new Set();
@@ -92,3 +99,3 @@
 // Modified SSE endpoint
-app.get('/events', async (req, res) => {
+app.get('/events', limiter, async (req, res) => {
   res.setHeader('Content-Type', 'text/event-stream');
EOF
@@ -5,2 +5,3 @@
import dotenv from 'dotenv';
import rateLimit from 'express-rate-limit';

@@ -76,2 +77,8 @@

// Set up rate limiter: maximum of 100 requests per 15 minutes
const limiter = rateLimit({
windowMs: 15 * 60 * 1000, // 15 minutes
max: 100, // max 100 requests per windowMs
});

const clients = new Set();
@@ -92,3 +99,3 @@
// Modified SSE endpoint
app.get('/events', async (req, res) => {
app.get('/events', limiter, async (req, res) => {
res.setHeader('Content-Type', 'text/event-stream');
dashboard/package.json
Outside changed files

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/dashboard/package.json b/dashboard/package.json
--- a/dashboard/package.json
+++ b/dashboard/package.json
@@ -19,3 +19,4 @@
     "react": "^18.3.1",
-    "react-dom": "^18.3.1"
+    "react-dom": "^18.3.1",
+    "express-rate-limit": "^7.4.1"
   },
EOF
@@ -19,3 +19,4 @@
"react": "^18.3.1",
"react-dom": "^18.3.1"
"react-dom": "^18.3.1",
"express-rate-limit": "^7.4.1"
},
This fix introduces these dependencies
Package Version Security advisories
express-rate-limit (npm) 7.4.1 None
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
dashboard/src/server/index.js
Comment on lines +111 to +113
app.get('*', (req, res) => {
res.sendFile(join(__dirname, '../../dist/index.html'));
});

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a file system access
Loading
, but is not rate-limited.

Copilot Autofix AI 2 months ago

To fix the problem, we need to introduce rate limiting to the Express application. The best way to do this is by using the express-rate-limit package, which allows us to set a maximum number of requests that can be made to the server within a specified time window. This will help prevent abuse and mitigate the risk of denial-of-service attacks.

We will:

  1. Install the express-rate-limit package.
  2. Import the package in the dashboard/src/server/index.js file.
  3. Set up a rate limiter with appropriate configuration.
  4. Apply the rate limiter to the specific route handler that performs the file system access.
Suggested changeset 2
dashboard/src/server/index.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/dashboard/src/server/index.js b/dashboard/src/server/index.js
--- a/dashboard/src/server/index.js
+++ b/dashboard/src/server/index.js
@@ -5,2 +5,3 @@
 import dotenv from 'dotenv';
+import rateLimit from 'express-rate-limit';
 
@@ -74,2 +75,9 @@
 const app = express();
+
+// Set up rate limiter: maximum of 100 requests per 15 minutes
+const limiter = rateLimit({
+  windowMs: 15 * 60 * 1000, // 15 minutes
+  max: 100, // max 100 requests per windowMs
+});
+
 const PORT = 3322;
@@ -110,3 +118,3 @@
 // Serve index.html for all routes
-app.get('*', (req, res) => {
+app.get('*', limiter, (req, res) => {
   res.sendFile(join(__dirname, '../../dist/index.html'));
EOF
@@ -5,2 +5,3 @@
import dotenv from 'dotenv';
import rateLimit from 'express-rate-limit';

@@ -74,2 +75,9 @@
const app = express();

// Set up rate limiter: maximum of 100 requests per 15 minutes
const limiter = rateLimit({
windowMs: 15 * 60 * 1000, // 15 minutes
max: 100, // max 100 requests per windowMs
});

const PORT = 3322;
@@ -110,3 +118,3 @@
// Serve index.html for all routes
app.get('*', (req, res) => {
app.get('*', limiter, (req, res) => {
res.sendFile(join(__dirname, '../../dist/index.html'));
dashboard/package.json
Outside changed files

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/dashboard/package.json b/dashboard/package.json
--- a/dashboard/package.json
+++ b/dashboard/package.json
@@ -19,3 +19,4 @@
     "react": "^18.3.1",
-    "react-dom": "^18.3.1"
+    "react-dom": "^18.3.1",
+    "express-rate-limit": "^7.4.1"
   },
EOF
@@ -19,3 +19,4 @@
"react": "^18.3.1",
"react-dom": "^18.3.1"
"react-dom": "^18.3.1",
"express-rate-limit": "^7.4.1"
},
This fix introduces these dependencies
Package Version Security advisories
express-rate-limit (npm) 7.4.1 None
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
dashboard/src/server/index.js
Comment on lines +122 to +139
app.post('/update', async (req, res) => {
const update = req.body;

try {
if (update.type === 'newTest' || update.type === 'updateTest') {
await appPool.query(
'INSERT INTO test_runs (id, data) VALUES ($1, $2) ON CONFLICT (id) DO UPDATE SET data = $2',
[update.data.id, update.data]
);
}

broadcastUpdate(update);
res.sendStatus(200);
} catch (error) {
console.error('Error updating data:', error);
res.sendStatus(500);
}
});

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.

Copilot Autofix AI 2 months ago

To fix the problem, we will introduce rate limiting to the Express application using the express-rate-limit package. This package allows us to set a maximum number of requests that can be made to the server within a specified time window. We will apply this rate limiting middleware to the /update endpoint to prevent abuse.

  1. Install the express-rate-limit package.
  2. Import the express-rate-limit package in the dashboard/src/server/index.js file.
  3. Configure the rate limiter with appropriate settings (e.g., maximum number of requests and time window).
  4. Apply the rate limiter middleware to the /update endpoint.
Suggested changeset 2
dashboard/src/server/index.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/dashboard/src/server/index.js b/dashboard/src/server/index.js
--- a/dashboard/src/server/index.js
+++ b/dashboard/src/server/index.js
@@ -5,2 +5,3 @@
 import dotenv from 'dotenv';
+import rateLimit from 'express-rate-limit';
 
@@ -74,2 +75,6 @@
 const app = express();
+const limiter = rateLimit({
+  windowMs: 15 * 60 * 1000, // 15 minutes
+  max: 100, // limit each IP to 100 requests per windowMs
+});
 const PORT = 3322;
@@ -121,3 +126,3 @@
 // Modified update endpoint
-app.post('/update', async (req, res) => {
+app.post('/update', limiter, async (req, res) => {
   const update = req.body;
EOF
@@ -5,2 +5,3 @@
import dotenv from 'dotenv';
import rateLimit from 'express-rate-limit';

@@ -74,2 +75,6 @@
const app = express();
const limiter = rateLimit({
windowMs: 15 * 60 * 1000, // 15 minutes
max: 100, // limit each IP to 100 requests per windowMs
});
const PORT = 3322;
@@ -121,3 +126,3 @@
// Modified update endpoint
app.post('/update', async (req, res) => {
app.post('/update', limiter, async (req, res) => {
const update = req.body;
dashboard/package.json
Outside changed files

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/dashboard/package.json b/dashboard/package.json
--- a/dashboard/package.json
+++ b/dashboard/package.json
@@ -19,3 +19,4 @@
     "react": "^18.3.1",
-    "react-dom": "^18.3.1"
+    "react-dom": "^18.3.1",
+    "express-rate-limit": "^7.4.1"
   },
EOF
@@ -19,3 +19,4 @@
"react": "^18.3.1",
"react-dom": "^18.3.1"
"react-dom": "^18.3.1",
"express-rate-limit": "^7.4.1"
},
This fix introduces these dependencies
Package Version Security advisories
express-rate-limit (npm) 7.4.1 None
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
@wojciechos wojciechos closed this Nov 27, 2024
@wojciechos wojciechos deleted the dashboard branch December 17, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wojciechos