Fix SubscribeTransactionStatus with new Juno update

NethermindEth · Jan 31, 2025 · 03ba2e3 · 03ba2e3
1 parent 4cf22d8
commit 03ba2e3
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/rpc/websocket.go b/rpc/websocket.go
@@ -93,14 +93,9 @@ func (provider *WsProvider) SubscribePendingTransactions(ctx context.Context, pe
 //   - clientSubscription: The client subscription object, used to unsubscribe from the stream and to get errors
 //   - error: An error, if any
 func (provider *WsProvider) SubscribeTransactionStatus(ctx context.Context, newStatus chan<- *NewTxnStatusResp, transactionHash *felt.Felt) (*client.ClientSubscription, error) {
-	sub, err := provider.c.SubscribeWithSliceArgs(ctx, "starknet", "_subscribeTransactionStatus", newStatus, transactionHash, WithBlockTag("latest"))
+	sub, err := provider.c.SubscribeWithSliceArgs(ctx, "starknet", "_subscribeTransactionStatus", newStatus, transactionHash)
 	if err != nil {
-		return nil, tryUnwrapToRPCErr(err, ErrTooManyBlocksBack, ErrBlockNotFound)
+		return nil, tryUnwrapToRPCErr(err)
 	}
-	// TODO: wait for Juno to implement this. This is the correct implementation by the spec
-	// 	sub, err := provider.c.SubscribeWithSliceArgs(ctx, "starknet", "_subscribeTransactionStatus", newStatus, transactionHash)
-	// 	if err != nil {
-	// 		return nil, tryUnwrapToRPCErr(err)
-	// 	}
 	return sub, nil
 }