Rianhughes/07 get block with receipts #517
Conversation
|
Todo: update tests when juno supports rpc v07 |
|
The PR, in general, looks good, however, it still needs to be updated as per your comment. I can have a look again after you have updated it. |
rpc/block.go
Outdated
| return &block, nil | ||
| } | ||
|
|
||
| // if result.Status == nil it's a pending block |
There was a problem hiding this comment.
This is incorrect, please see here. If the block is pending then the status should be "PENDING".
There was a problem hiding this comment.
getBlockWithReceipts can return a BLOCK_WITH_RECEIPTSwhich has a BLOCK_STATUS (which may be "PENDING"), however getBlockWithReceipts can also return a distinct type PENDING_BLOCK_WITH_RECEIPTS which has no BLOCK_STATUS.
There was a problem hiding this comment.
The naming could be clearer tbh (on the spec side), but I think the current implementation is correct.
There was a problem hiding this comment.
I've updated the logic to make this a bit clearer, but it's essentially the same
There was a problem hiding this comment.
Yeah looks like the spec is ambiguous
closes #516
Edit: This PR incorporates the changes from rc-1 which relate to block receipts