Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure starknet_call calldata is not null #658

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Ensure starknet_call calldata is not null #658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4209715
fix: Fix function call calldata possibly nil
Hyodar Jan 22, 2025
cf24819
refactor: Remove empty calldata package var
Hyodar Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rpc/call.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ import (
// - []*felt.Felt: the result of the function call
// - error: an error if any occurred during the execution
func (provider *Provider) Call(ctx context.Context, request FunctionCall, blockID BlockID) ([]*felt.Felt, error) {
if request.Calldata == nil {
request.Calldata = []*felt.Felt{}
}

var result []*felt.Felt
if err := do(ctx, provider.c, "starknet_call", &result, request, blockID); err != nil {
return nil, tryUnwrapToRPCErr(err, ErrContractNotFound, ErrContractError, ErrBlockNotFound)
Expand Down
Loading